fix(desktop): preview CDP sessions no longer hard-crash the app - #9068
Effect Service Conventions: Complete
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
🔍 Agent activity — 5 tool calls
💭 I'm looking at the diff that pins the debugger reference, then checking Manager.ts for any convention violations.
1. browse_code — apps/desktop/src/preview/Manager.ts
2. browse_code — apps/desktop/src/preview/Manager.ts
💭 Imports look fine with the namespace approach. Now I'm checking the changed regions around lines 1000-1250 and 2340-2400 for other convention issues, like whether there are leftover wc.debugger usages that should instead use control.debugger.
3. browse_code — apps/desktop/src/preview/Manager.ts
4. git_tools — wc.debugger
💭 The remaining debugger statement occurs before session creation, so that's acceptable as a pre-attach check. Since this is a bug fix that changes behavior, adding a large test seems justified rather than a violation of "no tests for mechanical refactors." I'm scanning for any other convention issues like error handling patterns. Nothing new gets added: imports stay the same, no lint suppressions, no ManagedRuntime or Layer.succeed usage. The test does use
as neverfor the mock, which is a type-checking bypass rather than a diagnostic-disabling directive like eslint-disable, so I want to check whether the existing tests in the file already do this too.
5. git_tools — as never|ts-expect-error|eslint-disable|biome-ignore
💭 No violations found here, consistent with the existing style. Since there's nothing to flag, I'll produce the success-state response with a summary noting all clear.
Agent Credits: 32 credits
Token usage: 8 uncached input · 83,642 cache-read input · 35,335 cache-write input · 1,531 output
Agent Credits may also include non-token charges from external tools such as web research.