Skip to content

fix(server): stop OpenCode child sessions - #9005

Merged
t3dotgg merged 2 commits into
mainfrom
t3code/fix-opencode-subagent-stop
Sep 1, 2026
Merged

t3dotgg merged 2 commits into
mainfrom
t3code/fix-opencode-subagent-stop

fix(server): bound OpenCode child cleanup requests

c463930
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check succeeded Sep 1, 2026 in 1m 20s

No issues identified (1 code object reviewed).

• Reviewed files modified since 196548d; other PR files not modified since then were skipped.
• Merge Base: ce71c04
• Head: c463930

Details

✅ File Path U3 Bytes Comments Posted Reason
➖ apps/server/src/provider/Layers/OpenCodeAdapter.test.ts 4213 Excluded by default ignore patterns
✅ apps/server/src/provider/Layers/OpenCodeAdapter.ts 2022 0

Billed Total: 10.00KB of diff | $0.50 (This review was charged at our per-review byte minimum of 10.00KB. Learn more here)

Filtered Issues Details

apps/server/src/provider/Layers/OpenCodeAdapter.ts
  • line 707: requestSemaphore only wraps requests made by the descendant walk. During interruptTurn, the parent session.abort can still be in flight when an abort acknowledgement starts this walk; the existing test deliberately holds that parent request while child cleanup begins. With eight children, this code then starts eight child requests in addition to the outstanding parent request, so it reaches nine concurrent SDK requests rather than the intended limit of eight. [ Already posted ]