-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix(web): keep settled thread notice compact #8980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4962,14 +4962,19 @@ function ChatViewContent(props: ChatViewProps) { | |||||||||||||||||||||||||||||
| return null; | ||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||
| const isSnoozed = activeThreadSnoozed; | ||||||||||||||||||||||||||||||
| const parkedThreadDescription = isSnoozed | ||||||||||||||||||||||||||||||
| ? "Sending a message wakes it and moves it back to Active in the sidebar." | ||||||||||||||||||||||||||||||
| : "Send a message to unsettle"; | ||||||||||||||||||||||||||||||
| return { | ||||||||||||||||||||||||||||||
| id: `thread-${isSnoozed ? "snoozed" : "settled"}:${activeThread?.id ?? "unknown"}`, | ||||||||||||||||||||||||||||||
| variant: "info", | ||||||||||||||||||||||||||||||
| icon: isSnoozed ? <AlarmClockIcon /> : <CheckCircle2Icon />, | ||||||||||||||||||||||||||||||
| title: `This thread is ${isSnoozed ? "snoozed" : "settled"}`, | ||||||||||||||||||||||||||||||
| description: isSnoozed | ||||||||||||||||||||||||||||||
| ? "Sending a message wakes it and moves it back to Active in the sidebar." | ||||||||||||||||||||||||||||||
| : "Sending a message moves it back to Active in the sidebar.", | ||||||||||||||||||||||||||||||
| title: ( | ||||||||||||||||||||||||||||||
|
macroscopeapp[bot] marked this conversation as resolved.
|
||||||||||||||||||||||||||||||
| <> | ||||||||||||||||||||||||||||||
| <span>This thread is {isSnoozed ? "snoozed" : "settled"}</span>{" "} | ||||||||||||||||||||||||||||||
| <span className="font-normal text-muted-foreground">{parkedThreadDescription}</span> | ||||||||||||||||||||||||||||||
| </> | ||||||||||||||||||||||||||||||
| ), | ||||||||||||||||||||||||||||||
|
Comment on lines
+4972
to
+4977
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Inlining the detail as a bare fragment drops the one-line guards the other inline-detail banner titles use.
Suggested change
Posted via Macroscope — UI Consistency |
||||||||||||||||||||||||||||||
| actions: ( | ||||||||||||||||||||||||||||||
| <Button | ||||||||||||||||||||||||||||||
| size="xs" | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor consistency: the settled branch is now a terse fragment while the snoozed branch above stays a full sentence in the same slot, and it drops the "back to Active in the sidebar" cue that the sidebar state change relies on. It also says "unsettle" while the action button in the same row is labeled "Un-settle". Consider keeping both branches in one voice and terminology.
Posted via Macroscope — UI Consistency