Skip to content

fix(web): new threads keep the viewed thread's model - #8892

Open
Gigioxx wants to merge 1 commit into
pingdotgg:mainfrom
Gigioxx:fix/new-thread-carries-model
Open

fix(web): new threads keep the viewed thread's model#8892
Gigioxx wants to merge 1 commit into
pingdotgg:mainfrom
Gigioxx:fix/new-thread-carries-model

Conversation

@Gigioxx

@Gigioxx Gigioxx commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Since #6011 the project default model outranks the model carried from the thread being viewed. Every project gets a default seeded at creation (the first selectable provider's default), so in practice a new thread always reset to that model instead of keeping the one the user was working with. Runtime and interaction modes still carried; only the model was lost.

This flips the priority in resolveNewThreadModelSelectionOverride: the carried selection wins, and the project default only fills in when there is nothing to carry (fresh app, or the draft would carry from itself). Mobile is unaffected since its new-task flow has no viewed-thread carry.

Validation

  • vp test run apps/web/src/lib/chatThreadActions.test.ts (10 tests)
  • vp fmt --check and vp lint on the touched files
  • vp run --filter @t3tools/web typecheck

Built with Claude Fable 5 in Claude Code.


Note

Low Risk
Localized priority change in new-thread model resolution with updated unit tests; no auth, data, or API surface changes.

Overview
New-thread model selection no longer resets to the project default when the user was already working with a different model on the thread they were viewing.

resolveNewThreadModelSelectionOverride now prefers the carried composer/thread model over the project default (which is always seeded at project creation). The project default is only applied when there is nothing to carry—e.g. cold start or when the destination draft would carry from itself. Comments in useHandleNewThread are updated to match.

Tests are updated and extended to assert carried-over-wins, plus fallback to project default when carry is absent.

Reviewed by Cursor Bugbot for commit 759df78. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix resolveNewThreadModelSelectionOverride to prefer carried model over project default

  • New threads now inherit the viewed thread's model, runtime mode, and interaction mode, with the carried model taking precedence over the project default.
  • chatThreadActions.ts reverses the precedence in resolveNewThreadModelSelectionOverride: it returns the carried selection when present, and falls back to the project default only when there is nothing to carry (including when source and destination draft IDs match).
  • chatThreadActions.test.ts updates tests to expect carried-selection precedence and adds a fallback-to-default test.
  • Behavioral Change: resolveNewThreadModelSelectionOverride no longer lets the project default override a carried selection; consumers relying on the old order will see carried selections win.

Macroscope summarized 759df78.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0db59ed6-6171-40f7-a0ff-32bc0bb031db

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Aug 31, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — New threads will now favor the viewed thread’s model over the configured project default whenever both are available, changing the product’s effective default-selection behavior. The change is localized and tested, but that default-policy change warrants human review.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant