Skip to content

fix(server): close sessions when provider turns abort - #8859

Closed
hahasagined wants to merge 1 commit into
pingdotgg:mainfrom
hahasagined:fix/provider-aborted-session-lifecycle
Closed

hahasagined wants to merge 1 commit into
pingdotgg:mainfrom
hahasagined:fix/provider-aborted-session-lifecycle

fix(server): close sessions when provider turns abort

891ab7d
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Aug 31, 2026 in 23s

All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — 2 tool calls

💭 Let me check the changed file to see if conventions apply here—the changes look behavioral, involving lifecycle handling in ProviderRuntimeIngestion.ts plus its tests, so I want to inspect that area closely.

1. browse_code — apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.ts

2. browse_code — apps/server/src/orchestration/Layers/ProviderRuntimeIngestion.ts

💭 These are behavioral changes to existing legacy files, and the Effect service convention checks don't appear to be violated since the touched code isn't creating, moving, or refactoring a service improperly—the namespace imports and shape references are pre-existing. Since this is a behavior change rather than a mechanical refactor, adding focused tests is appropriate rather than excessive, so I'm now checking the remaining diff sections. Everything looks clean with no convention issues. Given the check defaults to failure but this instance has no findings, I need to reconcile the "All clear" instruction with the required JSON output format, so I'll produce a JSON response with success state and "All clear" as the summary.


Agent Credits: 24 credits

Token usage: 4 uncached input · 25,185 cache-read input · 30,430 cache-write input · 862 output
Agent Credits may also include non-token charges from external tools such as web research.