feat(web): add opt-in panel animations - #8830
Merged
maria-rcks merged 29 commits intoSep 2, 2026
Merged
MacroscopeApp / Macroscope - Correctness Check
succeeded
Sep 2, 2026 in 2m 11s
No issues identified (17 code objects reviewed).
• Reviewed files modified since
b43b45b; other PR files not modified since then were skipped.
• Merge Base:e7deb2a
• Head:68a55c6
Details
| ✅ | File Path | U3 Bytes | Comments Posted | Reason |
|---|---|---|---|---|
| ✅ | apps/web/src/panelAnimations.ts |
4740 | 0 | |
| ✅ | apps/web/src/components/settings/PanelAnimationsPreview.tsx |
2455 | 0 | |
| ➖ | packages/contracts/src/settings.test.ts |
1016 | Excluded by default ignore patterns | |
| ✅ | apps/web/src/components/RightPanelSheet.tsx |
373 | 0 | |
| ✅ | apps/web/src/components/RightPanelTabs.tsx |
867 | 0 | |
| ✅ | apps/web/src/components/chat/ChatHeader.tsx |
968 | 0 | |
| ✅ | apps/web/src/components/AppSidebarLayout.tsx |
242 | 0 | |
| ✅ | apps/web/src/components/ui/sidebar.tsx |
4443 | 0 | |
| ✅ | apps/web/src/components/ui/sheet.tsx |
1714 | 0 | |
| ✅ | apps/web/src/components/settings/SettingsPanels.tsx |
1181 | 0 | |
| ✅ | apps/web/src/components/preview/PreviewPanelShell.tsx |
5048 | 0 | |
| ✅ | apps/web/src/routes/_chat.pull-requests.tsx |
1532 | 0 | |
| ✅ | apps/web/src/components/ChatView.tsx |
5970 | 0 |
Billed Total: 26.90KB of diff | $1.34
Saved $0.13 vs. the upper-bound estimate of $1.48 — cached code objects from prior reviews on this PR were not re-billed.
Filtered Issues Details
apps/web/src/components/ChatView.tsx
- line 1075: When an active drawer is closed, the new condition keeps
ThreadTerminalDrawermounted atgrid-rows-[0fr]. Its activeTerminalViewportstill hasautoFocus, and the changedfocusRequestId(it loses thevisible ? 1 : 0increment) triggers its focus effect, so its next animation-frame callback focuses the now-hidden terminal and steals focus from the composer that the close path attempts to focus. [ Already posted ]
Loading