fix(android): prevent last thread line from clipping at bottom - #8800
Fluffy-Bunny-23 wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
c8ad171 to
984fcac
Compare
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Adds 12 points of bottom padding to the thread list, giving the final message line room above the composer. The isolated layout change has no data, API, business-logic, or infrastructure impact. You can add or adjust custom eligibility rules. Learn more. |
02b4302 to
1d03803
Compare
Long assistant replies on Android could end with the last line half visible. The thread list had top padding but no bottom padding, so the final line sat right against the composer. This adds 12pt bottom padding to the ThreadFeed content container. The last line now has room to render fully. Note: pingdotgg#8220 fixes the same symptom on iOS with a native layout change. It does not affect Android. Implemented with: muse-1.2-contributor in opencode with opencode go through t3 code
1d03803 to
34bf7ca
Compare
Fixes reproduced on an Android emulator and from upstream reports. Feed: Android stops drawing a text view past the GPU's maximum texture height, so a long list rendered as one selectable Text lost its tail and took seconds per frame to draw. Long lists now split into 40-item chunks. Wide assistant markdown blocks keep a pinned width; the feed reserves bottom padding. Keyboard: the feed re-pins after keyboard transitions settle and when the composer collapses; the back gesture collapses the composer; sticky composers only follow the keyboard after a fresh show or real focus (upstream pingdotgg#8212). Terminal: hardware Enter no longer moves focus off the terminal; keyboards that use deleteSurroundingText (FUTO) send Backspace; forward delete works. Also: stream haptics no longer buzz every 320ms on Android and all haptics use the system engine; thread settings apply on tap without Save; typed pairing codes are normalized to the server format; non-git projects fall back to the current checkout instead of a dead worktree default; user CA certificates are trusted; Ctrl/Cmd+Enter sends from a hardware keyboard; thread rename, project favicons in the filter, tablet sidebar toggle, desktop-window density, route titles, Material You review colors, bottom gesture-bar insets, and the composer placeholder clipping (upstream PRs pingdotgg#11503, pingdotgg#11370, pingdotgg#11339, pingdotgg#8200, pingdotgg#8717, pingdotgg#11445, pingdotgg#6003, pingdotgg#5052, pingdotgg#8362, pingdotgg#10709, pingdotgg#11611, pingdotgg#8800, adapted).
Long assistant replies on Android could end with the last line half visible. The thread list had top padding but no bottom padding, so the final line sat right against the composer.
This adds 12pt bottom padding to the ThreadFeed content container. The last line now has room to render fully.
Note: #8220 fixes the same symptom on iOS with a native layout change. It does not affect Android.
Implemented with: muse-1.2-contributor in opencode with opencode go through t3 code
Note
Low Risk
Single layout padding tweak in the mobile thread list with no auth, data, or API impact.
Overview
On Android, the last line of long assistant replies could sit flush against the composer and render partially clipped because the thread list only had top inset padding.
This adds
paddingBottom: 12to theKeyboardAwareLegendListcontentContainerStyleinThreadFeed, mirroring the existing 12pt top padding so the final message line has space above the input area. iOS uses a separate native layout fix (#8220); this change targets Android only.Reviewed by Cursor Bugbot for commit 34bf7ca. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add bottom padding to
ThreadFeedlist to prevent clippingAdds
paddingBottom: 12tocontentContainerStylein ThreadFeed.tsx. This stops the last thread line from being clipped at the bottom of the screen.Macroscope summarized 34bf7ca.