feat(web): filter sidebar from thread menu

[saphid]

Filtering to a thread’s project currently requires opening the project picker in the sidebar header. This adds “Filter by ” to the sidebar thread’s context menu, changing to “Show all projects” when that project is already selected.

The action reuses the existing persisted project scope and resolves projects by environment and project ID. It leaves the open thread in place and shares the project-group lookup with “Project settings”. The chat-header menu omits this sidebar-only action.

Rebased onto main at c542b781c6. Upstream project-scope persistence (#9416), thread-menu project settings (#8925), and the compact sidebar header (#11315) are retained; none supplies this shortcut. No new store, wire contract, or server behavior is needed.

Verification

• vp test run apps/web/src/components/threadActionMenu.logic.test.ts apps/web/src/components/Sidebar.logic.test.ts: 169 passed.
• vp run typecheck in apps/web: passed after refreshing local dependencies with vp i.
• vp lint and vp fmt --check on the four changed files: passed; existing Sidebar lint warnings remain.
• Independent read-only Claude Fable 5 high review: two minor comment/test findings fixed, then no actionable findings on the final patch; process exit 0. The 12 menu tests and web typecheck passed again after those fixes.

Web and desktop share this menu. Native mobile uses a separate thread list and is unchanged. Desktop shell and remote/relay connections were not exercised; project matching includes the environment ID. The existing project picker remains another way to set or clear the same scope.

Before and after

These are earlier full-web-client recordings, using five threads across Harbor and cedar, light theme, at 1280×800. The GIFs focus on the sidebar. They show the same menu labels, icon, filter/reset actions and retained open thread as this patch. Upstream has since folded the project picker into the search row (#11315), so the surrounding header is older; these are not fresh captures of the rebased head. Both GIFs and linked MP4s were downloaded and decoded successfully during this update.

Before: the thread menu has no project-filter action.

After: “Filter by Harbor” hides the cedar thread; “Show all projects” restores it. The open Harbor thread stays selected.

Before recording · After recording

Coordination trace: T3 thread aaade76d-4ec0-4717-96ed-490d10a783a9

Updated with GPT-6 in the Codex harness (T3 Code). Independent review: Claude Fable 5 high via direct Claude Code CLI.

Summary by CodeRabbit

• New Features

  • Added project filtering to thread context menus.
  • Users can filter the sidebar by a thread’s project or return to viewing all projects.
  • Menu labels and availability now reflect the currently active project scope.
  • Project filtering is available when a thread belongs to a recognized project.

• Tests

  • Added coverage for project-filter menu visibility, labels, icons, and ordering.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 182f0507-35db-4d09-88b9-0abb7a5edd89

📥 Commits

Reviewing files that changed from the base of the PR and between a352597 and 44fa39e.

📒 Files selected for processing (3)

• apps/web/src/components/Sidebar.tsx
• apps/web/src/components/threadActionMenu.logic.test.ts
• apps/web/src/components/threadActionMenu.logic.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The thread action menu now supports project filtering. The sidebar resolves a thread’s project group, displays a filter or reset action, and updates the project scope. The chat-header menu keeps project filtering disabled.

Changes

Project filtering

Layer / File(s)	Summary
Project filter menu contract apps/web/src/components/threadActionMenu.logic.ts, apps/web/src/components/threadActionMenu.logic.test.ts, apps/web/src/hooks/useThreadActionMenu.ts	The menu supports conditional project-filter items with active and inactive labels. Tests validate visibility, icon, label, and order. The chat-header menu passes projectFilter: null.
Sidebar context-menu integration apps/web/src/components/Sidebar.tsx	The sidebar resolves the thread project group, passes project-filter metadata, toggles projectScopeKey, reuses the resolved group for project settings, and updates callback dependencies.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Sidebar
  participant ThreadActionMenu
  User->>Sidebar: Open thread context menu
  Sidebar->>ThreadActionMenu: Provide projectFilter
  ThreadActionMenu-->>Sidebar: Show filter or reset action
  User->>Sidebar: Select project-filter action
  Sidebar->>Sidebar: Set or clear projectScopeKey

Loading

Suggested reviewers: t3code, maria-rcks

Merge Risk: ⚪ Minimal · up to 44fa3

The project-filter action is gated appropriately and toggles the selected thread’s project scope without affecting the chat-header menu.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 6 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly summarizes the main change: adding sidebar filtering from a thread context menu.
Description check	✅ Passed	The description provides a clear change summary, rationale, UI recordings, verification results, scope limitations, and implementation context. It does not reproduce the template headings or checklist…

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

One finding: the new filter-by-project menu item is the only entry in the shared thread action menu without an icon, which misaligns its label in the web context-menu fallback. Details inline.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new context-menu workflow that changes the persisted sidebar scope and which threads are visible. The implementation is compact, but it modifies shared production sidebar behavior and lacks direct integration coverage for the dispatch path.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate c845a73

Dismissing prior approval to re-evaluate 723f161

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[saphid]

Reviewed the existing bot feedback against the rebased patch:

• The missing-icon finding remains fixed: both project-filter labels use the existing folder-tree icon, with focused menu coverage. The inline thread is already resolved.
• I am not adding docstrings solely to raise CodeRabbit’s coverage percentage. The current change adds no function, the project-filter state already documents its sidebar-only meaning, and AGENTS.md asks us to avoid narrating behavior that the source and tests already make clear. The warning also refers to six files, while this PR now changes four.
• Macroscope’s request for human review is acknowledged; this update does not treat bot checks as maintainer approval.

No maintainer review requests were present. Upstream #9416, #8925 and #11315 do not supersede this shortcut; the branch retains their behavior and is rebased without merge commits.

[saphid]

Latest-head follow-up (44fa39e048): all checks have completed successfully or are neutral/skipped; CodeRabbit reviewed this head with no actionable findings.

Macroscope’s updated approvability note is accurate about automated coverage: the focused tests cover menu construction and sidebar logic, not a full rendered context-menu dispatch. The PR includes earlier full-client recordings exercising filter and reset, with the older header and untested current-head integration explicitly disclosed. I am retaining that limit for human review rather than adding a callback-wiring test that AGENTS.md expressly discourages. The neutral approvability result is not being presented as maintainer approval. No functional correctness finding or unresolved inline thread remains.