feat(mcp): expose thread workspace inventory - #8685
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
Thread transfer impact
This comment will update automatically after the next completed run. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR adds a model-visible worktree inventory capability and substantially expands existing worktree status behavior across MCP, contracts, orchestration, and Git infrastructure. The cross-layer runtime impact and non-trivial inventory/path-resolution logic warrant human review. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
067be67 to
45486fb
Compare
|
Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON, but a cloud agent failed to start.
Reviewed by Cursor Bugbot for commit d1a6955. Configure here.
602bf69 to
9eaeae0
Compare
9eaeae0 to
bdd0832
Compare
07d53fd to
718558b
Compare
|
Superseded as the active MCP proposal by #10566 in the rebuilt MCP stack, following the maintainer request to review thin service wrappers separately from service hardening. This is not a full feature-parity replacement. This discovers branch-backed refs/worktrees only. Detached unbound inventory and switching an existing checkout require a shared service operation and are intentionally not rebuilt inside MCP. The old workspace work is retained for that extraction. Closing this mixed proposal without merging. The remote branch |

An agent can otherwise see only the branch and worktree path recorded on its thread, which does not establish whether Git agrees, which physical checkouts exist, or which live threads own them.
This change enriches
t3_worktree_statuswith separate recorded and actual state, and adds boundedt3_worktree_listdiscovery. A dedicated Git inventory path reports canonical repository common-directory and physical worktree-root identities, including detached and stale registrations, without changing the existing paginatedvcs.listRefswire/cache shape.Results are current-project scoped and read-only. Pages are sliced before status I/O; nested and symlinked recorded paths are resolved through actual Git identity; independent nested repositories are not misattributed; ordinary typed inventory failures make binding counts explicitly incomplete while interruption and defects propagate.
Focused validation:
vp run --filter t3 typecheckvp run --filter @t3tools/contracts typecheckvp run --filter @t3tools/shared typecheckvp run --filter @t3tools/client-runtime typecheckvp lint,vp fmt --check, andgit diff --checkReview base:
t3code/codex-turn-mappingat415ed0f73b97f1655b6282492f81d0b2bba3a9cc. Native stack: #8685 → #8680. This discovery layer does not add lifecycle pruning, revival, or cleanup.Implemented by GPT-5.6-Sol via Codex in T3 Code.