fix(mobile): harden native header toolbar items - #8611
Merged
Merged
MacroscopeApp / Macroscope - Correctness Check
succeeded
Aug 29, 2026 in 2m 46s
No issues identified (4 code objects reviewed).
• Merge Base:
3e6ab36
• Head:c410830
Details
| ✅ | File Path | U3 Bytes | Comments Posted | Reason |
|---|---|---|---|---|
| ➖ | pnpm-lock.yaml |
5726 | Excluded by default ignore patterns | |
| ✅ | patches/react-native-screens@4.26.2.patch |
36922 | 0 |
Billed Total: 36.92KB of diff | $1.85
Filtered Issues Details
patches/react-native-screens@4.26.2.patch
- line 1771:
onPressHeaderBarButtonItemstill lets a Mail toolbar callback ID collide with a normal toolbar button ID. For example, with a normal firstheaderToolbarItemsbutton and amailSearchToolbarwhosefilterButtonIdis"0-toolbar", the native filter button emits0-toolbar, but the newallItems.find(...)resolves the normal button first and returns before reachingonFilterPress. This is newly reachable now that mixed toolbar items are retained, so the filter/compose action invokes the wrong handler. [ Already posted ]
Loading