Skip to content

fix(mobile): harden native header toolbar items - #8611

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/fix-native-header-toolbar
Aug 29, 2026
Merged

juliusmarminge merged 1 commit into
mainfrom
t3code/fix-native-header-toolbar

fix(mobile): harden native header toolbar items

c410830
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Correctness Check succeeded Aug 29, 2026 in 2m 46s

No issues identified (4 code objects reviewed).

• Merge Base: 3e6ab36
• Head: c410830

Details

✅ File Path U3 Bytes Comments Posted Reason
➖ pnpm-lock.yaml 5726 Excluded by default ignore patterns
✅ patches/react-native-screens@4.26.2.patch 36922 0

Billed Total: 36.92KB of diff | $1.85

Filtered Issues Details

patches/react-native-screens@4.26.2.patch
  • line 1771: onPressHeaderBarButtonItem still lets a Mail toolbar callback ID collide with a normal toolbar button ID. For example, with a normal first headerToolbarItems button and a mailSearchToolbar whose filterButtonId is "0-toolbar", the native filter button emits 0-toolbar, but the new allItems.find(...) resolves the normal button first and returns before reaching onFilterPress. This is newly reachable now that mixed toolbar items are retained, so the filter/compose action invokes the wrong handler. [ Already posted ]