Skip to content

fix(codex): show sub-agent models - #8502

Merged
t3dotgg merged 1 commit into
mainfrom
t3code/fix/codex-subagent-model-display
Aug 28, 2026
Merged

t3dotgg merged 1 commit into
mainfrom
t3code/fix/codex-subagent-model-display

fix(codex): show sub-agent models

de16b30
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Aug 28, 2026 in 57s

All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — 7 tool calls

💭 I want to check the changed files for Effect conventions, focusing on CodexSessionRuntime.ts, CodexAdapter.ts, and ThreadBackgroundLiveness.ts to see how they're structured.

1. git_tools — ^import

2. git_tools — Effect.catch|Layer.succeed|ManagedRuntime|runPromise

💭 The catch-all error handling at line 1387 looks intentional and matches conventions, so that's fine. Now I want to check the imports at the top of the file to see where they're coming from.

3. browse_code — apps/server/src/provider/Layers/CodexSessionRuntime.ts

💭 The new code just consumes existing services rather than defining or refactoring any, using a request call with a catch-all error handler that intentionally swallows failures, which seems consistent with the established conventions. I'm checking ThreadBackgroundLiveness.ts too since the diff touches it, but only a single condition line changed within its existing sync-method object shape, so that's fine. Now I want to verify the test file's imports match the new usages of Fiber, Effect, Stream, and the node service helpers it references.

4. browse_code — apps/server/src/provider/Layers/CodexCollabRuntime.integration.test.ts

💭 Looking at CodexAdapter.ts, the mapping change removes timelineBypass and replaces title with linkage spread — that's a behavioral change beyond just Effect conventions, but since tests exist to cover it, it should be fine to let pass under the existing test requirement.

5. browse_code — apps/server/src/provider/Layers/CodexAdapter.ts

💭 Good, the linkage change looks like a consolidation rather than a regression. I'm scanning the new metadata state code in CodexSessionRuntime for convention issues, but it's just using Ref inside makeCodexSessionRuntime, which looks fine—no new error definitions or Layer.succeed patterns to flag. Now I'm checking decodeCodexChildResum for something worth verifying. The decode function's Effect.catch swallows both decode and RPC errors, which fits the convention since the whole channel is handled, and the timeout wrapping the decode chain behaves correctly. I'm double-checking ThreadBackgroundLiveness.ts and the client-runtime test changes, but those only touch a comment/condition and tests, so nothing else needs flagging. Let me also verify no new consolidated Effect import was introduced in CodexAdapter.test.ts or subagentRuntime.test.ts.

6. git_tools — from "effect"

7. browse_code — apps/server/src/orchestration/ThreadBackgroundLiveness.ts

💭 No violations found in the changed scope after checking the mock peer file and the raw request effect timing. Everything looks clear, so now I need to format the final response according to the required schema.


Agent Credits: 49 credits

Token usage: 12 uncached input · 199,414 cache-read input · 45,569 cache-write input · 2,979 output
Agent Credits may also include non-token charges from external tools such as web research.