-
Notifications
You must be signed in to change notification settings - Fork 5.1k
fix(server): make OpenCode health check resilient to terminal escapes and spaced model IDs #8391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Mostafa-Ben-Git
wants to merge
3
commits into
pingdotgg:main
from
Mostafa-Ben-Git:fix-opencode-health-check
+57
−11
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // Some CLIs (e.g. opencode <= 1.18) emit terminal escape sequences on stdout | ||
| // even when stdout is a pipe - most notably OSC title sets like | ||
| // `ESC ]0;<cwd>: ready BEL`. Anything that parses such output must strip them | ||
| // first, or the escapes leak into stored identifiers and slugs. | ||
|
|
||
| // OSC: `ESC ]` payload terminated by BEL or by ST (`ESC \`). | ||
| // eslint-disable-next-line no-control-regex -- matching control bytes is the point of this helper | ||
| const OSC_SEQUENCE = /\u001b\][^\u0007\u001b]*(?:\u0007|\u001b\\)/g; | ||
| // CSI: `ESC [` parameter bytes (including the ITU T.416 colon subparameter | ||
| // separator) and optional intermediate bytes, followed by a final byte in | ||
| // @-~ - ANSI colors, cursor movement, mode set/reset, ... | ||
| // eslint-disable-next-line no-control-regex -- matching control bytes is the point of this helper | ||
| const CSI_SEQUENCE = /\u001b\[[0-9:;?<=>]*[ -/]*[@-~]/g; | ||
|
|
||
| /** Removes OSC and CSI escape sequences from terminal output. */ | ||
| export function stripTerminalEscapes(text: string): string { | ||
| return text.replace(OSC_SEQUENCE, "").replace(CSI_SEQUENCE, ""); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI failure output never reaches users
Medium Severity
Non-zero
opencode modelsnow stores stdout and stderr onOpenCodeRuntimeError.causeand only puts character counts indetail.openCodeRuntimeErrorDetailand the health-check path readdetailonly, soFailed to execute OpenCode CLI health checkstill omits the CLI output needed to diagnose the failure.Reviewed by Cursor Bugbot for commit 2e6af7a. Configure here.