feat(swift-ios): present the command drawer catalog - #8350
Conversation
Define the command drawer geometry, gesture arbitration, responder ownership, and bounded focus renewal as a focused foundation slice. Restore the exact prior responder after an abandoned pull and cover cancellation, teardown, and eligibility paths with focused tests.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
… into pr-refresh/pr-7345-command-drawer
…350-proof-refresh
|
Closing this duplicate stack now that the complete drawer is consolidated and freshly proved in #7345. The #8350 head ( |
Summary
Adds the first production consumer of the command-drawer foundation from #7345.
WorkspaceViewdestinations.The parent PR owns geometry, gesture recognition, settling, keyboard bounds, and prior-responder restoration. This PR consumes that foundation without changing its lifecycle. Web, desktop, React Native mobile, server, contracts, providers, and persistence are unchanged.
Stack
GitHub cannot target this fork branch at an unmerged upstream PR, so the live upstream diff temporarily contains both layers. The presentation-only comparison is foundation
8b9a28d0a…consumerac3404a32.8b9a28d0a4f64a07a58e7553d59d444bbfa82841.ac3404a32d20735bc28faab12a61e210b87c49c3.b67837984e5650888b1eed0e1cd7fff83625f696, contained in both heads.Do not merge this draft before #7345 lands and the upstream file list shrinks to the four presentation files.
Validation
FeatureCommandDrawerTestsandFeatureCommandDrawerPresentationTests: 59 passed, 0 failed, 0 skipped with realxcodebuildexit 0.Implemented by GPT-5.6 Sol via the Codex harness.