Skip to content

feat(swift-ios): present the command drawer catalog - #8350

Closed
saphid wants to merge 6 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:feat/command-drawer-presentation-integration
Closed

feat(swift-ios): present the command drawer catalog#8350
saphid wants to merge 6 commits into
pingdotgg:t3code/rebuild-mobile-app-swiftfrom
saphid:feat/command-drawer-presentation-integration

Conversation

@saphid

@saphid saphid commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds the first production consumer of the command-drawer foundation from #7345.

  • Builds a bounded, searchable catalog from existing workspace actions, projects, and recent threads.
  • Renders the drawer, search field, scrim, empty state, and accessible result rows.
  • Maps selections to existing typed WorkspaceView destinations.
  • Wires the presentation over Home and open-thread workspace roots.

The parent PR owns geometry, gesture recognition, settling, keyboard bounds, and prior-responder restoration. This PR consumes that foundation without changing its lifecycle. Web, desktop, React Native mobile, server, contracts, providers, and persistence are unchanged.

Stack

GitHub cannot target this fork branch at an unmerged upstream PR, so the live upstream diff temporarily contains both layers. The presentation-only comparison is foundation 8b9a28d0a…consumer ac3404a32.

  • Foundation head: 8b9a28d0a4f64a07a58e7553d59d444bbfa82841.
  • Live consumer head: ac3404a32d20735bc28faab12a61e210b87c49c3.
  • Live target: b67837984e5650888b1eed0e1cd7fff83625f696, contained in both heads.

Do not merge this draft before #7345 lands and the upstream file list shrinks to the four presentation files.

Validation

  • Exact-head FeatureCommandDrawerTests and FeatureCommandDrawerPresentationTests: 59 passed, 0 failed, 0 skipped with real xcodebuild exit 0.
  • Current-head GitHub checks, including contract fixtures and native tests, pass.
  • Current review threads are resolved. This stack has no human maintainer approval.
  • PR-only media is absent from the product diff. Earlier combined-implementation media has been removed because it did not prove this live diff.

Implemented by GPT-5.6 Sol via the Codex harness.

saphid added 2 commits August 27, 2026 12:30
Define the command drawer geometry, gesture arbitration, responder ownership, and bounded focus renewal as a focused foundation slice. Restore the exact prior responder after an abandoned pull and cover cancellation, teardown, and eligibility paths with focused tests.
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22dee1a0-7821-434d-9d59-2a5f8d9e20b3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 27, 2026
Comment thread apps/swift-ios/Features/Workspace/FeatureCommandDrawerView.swift
@saphid

saphid commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

Closing this duplicate stack now that the complete drawer is consolidated and freshly proved in #7345. The #8350 head (ac3404a32) is an ancestor of #7345 head c1eef5a07; #7345 contains the full catalog/presentation diff plus the Home/thread entry, gesture lifecycle, exact responder restoration, scene-local review fix, 61 focused passing tests, and current-head media. No #8350-only file remains.

@saphid saphid closed this Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant