Skip to content

test(server): remove duplicate missing worktree test - #8252

Merged
t3-code[bot] merged 1 commit into
mainfrom
test/prune-useless-tests-20260826-041933
Aug 27, 2026
Merged

t3-code[bot] merged 1 commit into
mainfrom
test/prune-useless-tests-20260826-041933

test(server): remove duplicate missing worktree test

add029a
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Aug 26, 2026 in 32s

All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — 5 tool calls

💭 The diff just removes a test verifying that removing an already-gone worktree is a no-op, which is a coverage deletion rather than an obvious convention violation. I want to check the file and driver to see if that behavior is still tested elsewhere before flagging anything.

1. git_tools — Path.Path|makeTmpDir|removeWorktree — rejected: repo.url: required parameter is missing or empty;repo: required parameter is missing or empty

2. git_tools — add029a — rejected: repo.url: required parameter is missing or empty;repo: required parameter is missing or empty

3. git_tools — Path|makeTmpDir|removeWorktree

💭 The removed test checked that calling removeWorktree on a path that was never registered is a no-op, but there's a separate test at line 748 expecting an error for a "notAWorktree" path — I'm checking whether these two expectations actually conflict, and whether the remaining idempotency and stale-worktree tests still cover the behavior adequately.

4. browse_code — apps/server/src/vcs/GitVcsDriverCore.test.ts

5. browse_code — apps/server/src/vcs/GitVcsDriverCore.test.ts

💭 That removed test scenario is already covered elsewhere, so there's no real convention violation—everything looks clear. Given the schema requires structured output even when there are no findings, I'll represent this as a success state with "All clear" as the title and summary.


Agent Credits: 33 credits