fix(server): strip terminal escape sequences from opencode CLI output - #7988
Exotic209093 wants to merge 1 commit into
Effect Service Conventions: All clear
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
🔍 Agent activity — 2 tool calls
💭 I'm checking the changed files, particularly opencodeRuntime.ts and a new shared util, to see if they follow Effect service conventions. I want to look closer at the schema decoding usage and the try/catch block that silently returns an empty array on failure.
1. browse_code — apps/server/src/provider/opencodeRuntime.ts
2. browse_code — packages/shared/src/stripTerminalEscapes.ts
💭 This is a bug fix touching pure parsing helpers, not an Effect service refactor, so those conventions about Context.Service, layers, or errors don't really apply here. Swapping Schema.fromJsonString for manual JSON.parse with try/catch isn't a convention violation since it just returns an empty array on failure. I'm satisfied this looks clean overall, and I'll summarize my conclusion as "All clear."
Agent Credits: 26 credits