Skip to content

fix(contracts): reject project script ids that cannot form keybinding commands - #7947

Closed
IzonIcy wants to merge 2 commits into
pingdotgg:mainfrom
IzonIcy:fix/project-script-id-keybinding-crash
Closed

IzonIcy wants to merge 2 commits into
pingdotgg:mainfrom
IzonIcy:fix/project-script-id-keybinding-crash

Merge branch 'main' into fix/project-script-id-keybinding-crash

f5999a9
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Aug 23, 2026 in 6s

Effect Service Conventions: Complete

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — 3 tool calls

💭 This looks like a schema change rather than an Effect service change, so I'm checking whether it fits existing conventions in keybindings.ts and orchestration.ts. There's a new ProjectScriptId schema constant added and referenced across files, but nothing that raises circular import or service-pattern concerns—just a backend validation addition covered by new tests.

1. browse_code — packages/contracts/src/keybindings.ts

2. browse_code — packages/contracts/src/orchestration.ts

💭 This looks more like a schema/validation change than an Effect service change, so most conventions don't strictly apply—the ProjectScriptId export and stricter validation replacing TrimmedNonEmptyString seem fine, backed by added tests. I'm checking whether there's any circular import concern with keybindings.ts. There's a potential real-world issue if script ids elsewhere are generated as UUIDs, since tightening the schema could reject existing persisted data—but that's outside the scope of Effect service conventions I'm checking, and tests were added for the behavior change, so I'll note it as an aside rather than a blocking concern and lean toward concluding things look clear.

3. git_tools — randomUUID|scriptId|ProjectScript\b

💭 I don't see any Effect service convention issues in this diff, so everything looks clear. I'll format the final response as JSON with a summary stating "All clear."


Agent Credits: 0 credits
No billable model usage was recorded for this run.