feat(web): add appearance contrast control - #7906
Merged
Merged
MacroscopeApp / Macroscope - Correctness Check
succeeded
Aug 22, 2026 in 54s
No issues identified (2 code objects reviewed).
• Merge Base:
2c4158f
• Head:7bb0d15
Details
| ✅ | File Path | Comments Posted | Reason |
|---|---|---|---|
| ✅ | .macroscope/check-run-agents/ui-consistency.md |
0 | |
| ✅ | apps/web/src/browser/annotationTheme.ts |
0 |
Filtered Issues Details
apps/web/src/browser/annotationTheme.ts
- line 13:
readPreviewAnnotationThemenow reads the--contrast-*custom properties verbatim. Those properties are defined ascolor-mix(...)expressions containing references such asvar(--foreground)andvar(--appearance-contrast-base), andgetComputedStyle(...).getPropertyValue()does not resolve the contents of a custom property to a final color.PickPreloadlater installs this string as--t3-foregroundinside the unrelated preview page, where the referenced app theme variables are absent (or may have unrelated values), making the annotation overlay colors invalid or incorrect. This affects all six changed reads; they must be resolved to concrete colors before crossing into the preview document. [ Already posted ]
Loading