fix(web): keep the send action visible during active turns - #7868
fix(web): keep the send action visible during active turns#7868Exotic209093 wants to merge 1 commit into
Conversation
The send-while-running affordance added in pingdotgg#4781 was gated to mobile viewports only, so on desktop a composer with sendable content showed Stop alone while a turn ran, hiding the steer submit that Enter already performed. Send now renders alongside Stop whenever the composer has sendable content, on every viewport. ox-alpha via opencode
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This PR simplifies UI logic by removing a prop that conditionally showed the send button only on mobile during active turns. The change is small, self-contained, and properly tested - the send button now appears consistently across all viewports when there's sendable content. You can add or adjust custom eligibility rules. Learn more. |
|
Note 🤖 GPT-5.6 Sol responding on behalf of Theo We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together. This branch shows Send beside Stop during active turns on desktop and mobile. The same UI choice is already covered by open #7751, which remains open for review. We are closing this parallel implementation. If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed. |
Problem
While a turn is running, a desktop composer with sendable follow-up text showed only Stop. The send-while-running affordance from #4781 was gated to mobile viewports (\showSendWhileRunning={isMobileViewport}), so on desktop widths the steer submit that Enter already performs had no visible button.
Fix
Removed the viewport gate and the \showSendWhileRunning\ prop entirely. \ComposerPrimaryActions\ now renders Send alongside Stop whenever the composer has sendable content during a running turn, on every viewport. An empty composer still shows Stop only.
Fixes #7750
ox-alpha via opencode
Note
Low Risk
UI-only composer action visibility; no auth, data, or send-path logic changes.
Overview
Shows Send next to Stop whenever a running turn has sendable follow-up text, on all viewports—not only mobile.
Removes the
showSendWhileRunninggate that hid the button on desktop even though Enter already submitted. An empty composer still shows Stop only.Reviewed by Cursor Bugbot for commit 6d0e2d1. Configure here.
Note
Keep send button visible during active turns in
ChatComposershowSendWhileRunningprop fromComposerFooterPrimaryActionsandComposerPrimaryActions, so the send button is no longer gated on viewport or Enter-to-send availability.hasSendableContentis true, and the stop button uses the larger size under the same condition.showSendWhileRunningmust be updated.Macroscope summarized 6d0e2d1.