Repository navigation
feat(web): confirm before closing a terminal #7592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
724d03b
feat(web): confirm before closing a terminal
maria-rcks e3711ea
fix(web): confirm terminal close from the keybinding too
maria-rcks 92db33e
fix(web): swallow the close shortcut while a terminal close is pending
maria-rcks a620ebe
fix(web): cover terminal tab close confirmations
maria-rcks ec5d1c0
fix(web): describe split terminal closes
maria-rcks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { readLocalApi } from "~/localApi"; | ||
|
|
||
| /** | ||
| * Shared confirmation for every user-initiated terminal close (drawer buttons, | ||
| * panel buttons, and the `terminal.close` keybinding). Auto-exit cleanup skips | ||
| * this path and closes directly. | ||
| */ | ||
| export async function confirmTerminalClose(label: string): Promise<boolean> { | ||
| const localApi = readLocalApi(); | ||
| if (!localApi) return true; | ||
| return localApi.dialogs.confirm( | ||
| [`Close terminal "${label}"?`, "This stops the running process and clears its history."].join( | ||
| "\n", | ||
| ), | ||
| { variant: "destructive" }, | ||
| ); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.