feat(swift-ios): show how long completed threads have been done - #7399
feat(swift-ios): show how long completed threads have been done#7399saphid wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused iOS Home metadata adjustment that uses an existing completion timestamp, preserves slim-row and fallback behavior, and adds targeted formatting tests. Its runtime impact is limited to display and accessibility text, with no schema, workflow, infrastructure, or sensitive-data implications. You can add or adjust custom eligibility rules. Learn more. |
1f39d72 to
fce7740
Compare
7b1393e to
c618327
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c618327. Configure here.
Dismissing prior approval to re-evaluate 6d7966c
|
Updated after on-device review: the wording is gone. Completed rows now show the bare elapsed time since completion — What did not change is the substance of the feature: the age is still measured from Also in this update:
Same four files, Coordination trace: T3 thread 50F4FC2B-6485-41E5-80DA-BDCD2BE20428 · saphid/t3code-personal#119 |
Exact-head visual proof refreshedCaptured from PR head The completed
No video is needed because this change has no interaction or motion behavior. |
6d7966c to
b49d8b3
Compare
Dismissing prior approval to re-evaluate b49d8b3
b49d8b3 to
c61c020
Compare
Dismissing prior approval to re-evaluate c61c020
# Conflicts: # apps/swift-ios/App/NativeFeatureClient.swift
Dismissing prior approval to re-evaluate 8c177b5



Problem
Completed threads on SwiftUI Home used the thread's last-update time. A task updated after it finished could therefore look newer than its actual completion.
Implementation
Rich completed rows now use the existing latest-turn completion timestamp for their compact age and VoiceOver text. Invalid or missing completion timestamps keep the existing last-update fallback. Slim rows, non-completed states, the server, and other clients are unchanged.
Verification
git diff --check upstream/t3code/rebuild-mobile-app-swift...HEADpassed.Evidence
Current-head proof is prepared but not attached yet. The exact-head native build was refused before Xcode started because another delivery lane holds the native-build lease. Older captures are intentionally omitted.
Implemented with GPT-5.6 Sol in the Codex harness.