feat(desktop): import browser cookies into a profile - #7255
feat(desktop): import browser cookies into a profile#7255juliusmarminge wants to merge 58 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Reviewed the new BrowserImport service, its Chromium cookie helper, and the IPC/layer wiring against the Effect service conventions.
Service shape, module layout (Context.Service tag + inline interface, make, layer), namespace imports, and layer composition in main.ts all look correct. The findings below are about the error model: the new failure type is unstructured (reason: Schema.String) and every construction discards the underlying cause, including one that erases a structured BrowserSession error.
Posted via Macroscope — Effect Service Conventions
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
There was a problem hiding this comment.
UI Consistency
One finding in the changed browser-profiles UI (apps/web/src/components/settings/IntegrationsSettings.tsx).
The menu/primitive usage itself looks consistent with the shared system: Menu/MenuPopup/MenuItem/MenuSub from components/ui/menu, MenuTrigger render={<Button …/>} matching the existing pattern in PreviewMoreMenu/ProjectScriptsControl, existing size="icon-sm" / variant="ghost-muted" Button variants, min-w-* on popups honouring MenuPopup's width-defaulting contract, and the bordered list container matching the convention already used in ConnectionsSettings. aria-labels are preserved on both the rename input and the new row trigger.
The issue is a state-display regression introduced by removing the default-profile Select while filtering Incognito out of the new list: a stored default of incognito (which the removed Select allowed a user to pick) now leaves the section with no "Default" badge on any row.
Posted via Macroscope — UI Consistency
757f025 to
5853095
Compare
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR adds a substantial end-to-end browser-cookie import workflow involving Keychain access, native packaging, filesystem/database reads, and persistent Electron session writes. It also changes the browser-profile default settings surface, so the scope and data sensitivity warrant human review. You can add or adjust custom eligibility rules. Learn more. |
5853095 to
23b22b9
Compare
There was a problem hiding this comment.
Reviewed the new BrowserImport service, its Sources/ChromiumCookies helpers, the IPC method, and the layer wiring against the Effect service conventions. The service module follows the canonical shape (errors → Context.Service with inline interface → make → layer), dependencies are acquired from the environment, and the failure translations now keep a real cause. One remaining gap on error context.
Posted via Macroscope — Effect Service Conventions
There was a problem hiding this comment.
UI Consistency — 1 finding
The two issues flagged on earlier commits are addressed: loadSources now clears sources before each refresh, and resolvedDefaultId resolves against the rendered rows.
One consistency gap remains: with BrowserDefaultProfileSetting removed and Incognito no longer rendered as a row, the section can badge Default on a profile that is not the effective default (see inline comment).
Minor (not blocking): lines 507–529 now carry three consecutive doc comments for a single component — the "Create, rename, and remove browser profiles" and "Per-profile cookie import" blocks are leftovers from the removed/renamed pieces and could be folded into one.
Posted via Macroscope — UI Consistency
There was a problem hiding this comment.
Two findings in the reworked browser-profiles section. Both are about the settings UI now disagreeing with the runtime behaviour it configures, rather than styling.
Posted via Macroscope — UI Consistency
57fccc1 to
ea2efcb
Compare
3264ff7 to
76fc9d2
Compare
81292ec to
9796604
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON, but a cloud agent failed to start.
Reviewed by Cursor Bugbot for commit 3c41bf6. Configure here.
There was a problem hiding this comment.
One finding: the new selection tile in the import wizard misses the pointer cursor every other clickable surface in the app sets explicitly. Inline comment below.
Posted via Macroscope — UI Consistency
There was a problem hiding this comment.
One finding: Sources.ts reads the host name from the node:os global instead of the shared HostProcessHostname reference the rest of the codebase injects.
Posted via Macroscope — Effect Service Conventions
There was a problem hiding this comment.
One finding on the import wizard's result copy. (A previously flagged item — SelectableTile still missing cursor-pointer — remains open; not re-posted here.)
Posted via Macroscope — UI Consistency
There was a problem hiding this comment.
One finding: the import wizard renders the primary environment's raw catalog label, which reads "Local environment" where every other surface calls the same machine "This device".
Posted via Macroscope — UI Consistency

Stacked on #7272 (
shared-sqlite-client).Imports cookies from Helium on macOS into a T3 Code browser profile. Saved passwords and browsing history remain out of scope.
The app requests the browser key through the in-process Keychain API, so consent belongs to T3 Code. Denial stops the import; there is no permission bypass. Source databases are opened read-only and snapshotted consistently with SQLite before extraction.
The wizard chooses a source and destination, prevents profile edits during an import, and reports imported/skipped counts and affected sites. Plaintext and encrypted cookie records are handled separately; domain-bound records are validated. Partitioned cookies are skipped when their partition semantics cannot be preserved by Electron.
Validation includes synthetic decryption records, plaintext and legacy records, domain-binding failures, partitioned-cookie rejection, WAL snapshot consistency, interrupted writes, and wizard state transitions, plus scoped typechecks/lint. Earlier Helium imports were verified in the desktop app; this audit did not request another live Keychain read.
Original implementation: Claude Code. Review fixes: GPT-5.6 Sol agents, coordinated through Codex.
Note
Add browser cookie import into desktop profiles
BrowserImportservice to read, decrypt, and import cookies from Chromium-based browsers (currently Helium on macOS) into a specific Electron session partition.BrowserImportWizardcomponent in the settings UI to select source and target profiles, handle browser running states, and display import results.PREVIEW_IMPORT_SOURCES_CHANNELandPREVIEW_IMPORT_COOKIES_CHANNEL, and updates the desktop build script to stage@napi-rs/keyringnative binaries.readChromiumCookiesin ChromiumCookies.ts only supports macOS Keychain decryption; Windows/Linux will returnunsupportedPlatform. Build requires correct@napi-rs/keyringbinary staging or fails withKeyringNativePackageMissingError.Macroscope summarized 683ca1b.
Note
High Risk
Reads third-party cookie databases and macOS Keychain secrets, writes session cookies into Electron partitions, and touches profile persistence and partition lifecycle—security- and data-sensitive paths with substantial new surface area.
Overview
Adds cookie import from installed Chromium-family browsers (initially Helium on macOS) into T3 Code desktop browser profiles, wired through new preview IPC, a main-process
BrowserImportservice, and settings UI.On the desktop side, the app lists importable sources, blocks import while the source browser holds
SingletonLock, reads cookies via SQLite snapshot + macOS Keychain (@napi-rs/keyring, no CLI bypass), decrypts Chromium storage with host-only vs domain-cookie handling, schema 24 domain binding, and skips partitioned (CHIPS) cookies when Electron cannot preserve them. Cookies are written sequentially into the same Electron partition the preview webview uses (resolvePartitionScope). Profile directory names from IPC are validated against listed profiles to block path traversal.Integrations → Browser profiles gains an Add profile menu with blank profile and Import from entries, a multi-step
BrowserImportWizard(quit browser, pick source/target, counts and skipped domains), per-profile actions (set default, clear data, remove), andpersistClientSettingsUpdateso new profiles are persisted only after a successful import (with partition cleanup on failed registration). The separate default profile settings row is removed; default is set from the profile menu. Desktop artifacts stage@napi-rs/keyringnative binaries like other native addons.Reviewed by Cursor Bugbot for commit 683ca1b. Bugbot is set up for automated code reviews on this repo. Configure here.