Replace mode-toggle titles with styled tooltips - #696
Closed
ashleyww93 wants to merge 1 commit into
Closed
Conversation
- switch Chat and runtime mode buttons from `title` attributes to Tooltip UI with keyboard hint for plan toggle - use `aria-description` for accessibility text instead of native title tooltips - add default tooltip open/close delays and refresh tooltip popup styling - update browser tests to assert absence of `title` attributes
github-actions
Bot
added
the
vouch:unvouched
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
anonb3ll
added a commit
to anonb3ll/tcode
that referenced
this pull request
Aug 29, 2026
…pingdotgg#701) (#3) * feat(server): add Antigravity CLI provider protocol spike Establish the wire contract for driving the Antigravity (agy) CLI as a T3 provider: bounded plan-mode launch and resume argument construction, unavailable/unauthenticated/available classification, stream-json event parsing, and terminal-outcome normalization covering cancellation and missing terminal results. Protocol functions only. Nothing spawns a process or registers a provider, so the live provider catalog is unchanged. Verified against agy 1.1.22 by bounded read-only probe: init, step_update, and result envelopes match the fixtures, and --conversation resume continues step_index and reuses cached context. Spike authored by Desktop_Codex; recovered from a disposable checkout, independently re-verified, and committed by Laptop_Cursor. Task pingdotgg#642. * feat(provider): add Antigravity (agy) production provider adapter * fix(provider): harden Antigravity adapter for production follow-ups Real `agy models` auth probe, SIGINT/SIGTERM kill honesty, tool ERROR and CANCELED taxonomy, UA-owned approval via skip-permissions (no fake sandbox), and launchArgs/effort/runtimeMode hygiene. Focused tests cover the slices; live `agy models` probe exits 0 on this host. Co-authored-by: Cursor <cursoragent@cursor.com> * test(provider): update ProviderRegistry expectations for Antigravity Built-in antigravity was missing from catalog/spawn assertions, which failed the registry suite once the adapter landed. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Replaces native browser
titleattributes on the Chat and Runtime mode buttons with a proper Tooltip component, improving both visual consistency and accessibility.titleattributes on Chat and Runtime mode buttons for the Tooltip UI component, including a keyboard shortcut hint for the plan togglearia-descriptioninstead oftitlefor accessibility text, avoiding native tooltip behaviortitleattributes are no longer presentWhy
The app already had a styled tooltip component available, but these buttons were still using the default browser tooltip instead. I also wanted to surface the Shift+Tab shortcut more clearly, since it isn’t user-bindable and isn’t something people would discover unless they already use that shortcut elsewhere.
UI Changes
Before:
After:
Checklist
Note
Replace ChatView interaction and runtime toggle button
titleattributes with styled tooltips usingTooltip/TooltipPopupand default trigger delays (120ms open, 80ms close) in tooltip.tsxSwitch ChatView mode toggles to custom tooltips with
aria-description, update tooltip trigger defaults (delay 120ms, closeDelay 80ms), and adjust tooltip styling; update tests to assert notitleattributes.📍Where to Start
Start with the toggle render logic in ChatView.tsx, then review tooltip trigger/popup behavior in tooltip.tsx, and finally the updated expectations in ChatView.browser.tsx.
Macroscope summarized 5998d74.