Repository navigation
fix(desktop): app zoom no longer zooms the preview browser - #6649
Effect Service Conventions: All clear
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
🔍 Agent activity — reasoning, no tool calls
💭 I'm checking the modified files to understand the coding conventions being used, particularly looking at the new
reapplyZoomandassertTabZoommethods to see how they fit into the existing patterns. Now I'm checking the new zoom-related methods in Manager.ts and how DesktopWindow.ts uses the preview manager's zoom functionality. I'm trying to trace wherepreviewManageroriginates in the DesktopWindow constructor—it's likely coming fromyield* PreviewManager.PreviewManager, so let me verify that. Looking at the service interface declaration,reapplyZoomis defined as a function that returns an Effect with no value, and it's wired up in the test file through a test seam in the PreviewManager layer setup. Scanning through the rest of the interface and test conventions — the error handling uses the existingattemptpattern,Effect.ignoreis applied consistently in places likeassertTabZoom, and the test layer construction withLayer.succeedis standard for test doubles. The imports from "effect" look properly consolidated across the test files, and no consumer updates are needed since this is an internal service addition. The test layer for PreviewManager in DesktopWindow.test.ts uses a test seam through Layer.succeed, which is acceptable. I'm not seeing any new error classes or Layer.succeed calls in production code. One pattern I notice isattempt(...).pipe(Effect.ignore)in assertTabZoom that silently swallows failures, which isn't explicitly listed as a convention. Everything checks out cleanly. I need to return JSON matching the schema with a success state and "All clear" as the summary, since the audit found no issues despite checking for defaults to failure.
Agent Credits: 38 credits