fix(web): contain long approval commands - #6503
juliusmarminge merged 2 commits into
UI Consistency: All clear
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/ui-consistency.md
More information about how Check Run Agents work can be found in our Help Center.
🔍 Agent activity — reasoning, no tool calls
💭 Looking at the diff to see what's changed—there are a few small updates to ChatComposer's flex-wrap behavior and ComposerPendingApprovalPanel's width and overflow handling, plus some test modifications. Let me check the actual files to make sure these changes are correct. I'm checking the ChatComposer component around line 3056 to see how the approval panel is positioned and whether the parent containers have the min-w-0 constraint applied. I need to look at the ChatComposer context around line 3056 to see how the panel is being rendered and check if parent elements have the min-w-0 constraint that would allow proper text truncation. I'm noticing there's a null byte in the file, which suggests it might be binary data. Let me check a specific range around the 3000-3100 mark to see what's there. I'm trying to locate where ComposerPendingApprovalPanel is actually being used, so I'm searching through the ChatComposer file. The grep tools are hitting issues—binary file detection and null bytes in the file—so I'm switching to a different approach, maybe viewing specific sections or using code_research to find the panel's usage. I'm adding flex-wrap to the approval actions row in the expanded composer to match the mobile version, and updating the panel styling with min-width and max-width constraints plus overflow-wrap on the
<pre>element to handle long unbreakable strings better. I should check whether this Tailwind version has a built-inwrap-anywhereutility instead of using an arbitrary property — Tailwind v4.1+ supports it natively. Let me verify the repo's Tailwind version and see ifwrap-anywhereis used elsewhere to maintain consistency, though using an arbitrary property here isn't a blocker. Bothwrap-anywhereand the arbitrary property syntax are already used elsewhere in the codebase, so there's no inconsistency there. The test is checking for specific class strings like "min-w-0", "max-w-full", and "[overflow-wrap:anywhere]", which is a bit brittle but not unreasonable—it's not violating any UI consistency principles, just asserting implementation details. The test switched from a long repeated string to usingrepeat(500)to create a single unbreakable token, which is fine. I should verify whether the panel's width constraints actually matter—the form hasmax-w-3xl w-full min-w-0, but if the parent isn't a flex container, themin-w-0wouldn't have an effect. Theflex-wrapaddition to the actions row at line 3056 is reasonable; if buttons wrap withjustify-end, they'll stack right-aligned. The pre element'soverflow-autowithmax-h-40creates a nested scroll area, which is preexisting. I need to check the ComposerPendingApprovalActions component to see if the buttons themselves are handling overflow properly—the PR title suggests that's where the actual fix is. The buttons are using the shared primitive consistently, and the panel styling is all local Tailwind without any global CSS or theme overrides. I'm checking the text wrapping and overflow behavior on the pre element — the combination ofwhitespace-pre-wrapandoverflow-wrap: anywhereworks fine, and the scrollbar inside the rounded bordered container is already handled correctly. Removingbreak-wordsin favor ofanywhereis actually stronger and doesn't cause any regression. Everything checks out, so I'm marking this as all clear.
Agent Credits: 299 credits