Skip to content

fix(web): prevent multi-select questions from auto-advancing - #6443

Closed
effektsvk wants to merge 2 commits into
pingdotgg:mainfrom
effektsvk:t3code/fix-multi-select-auto-submit
Closed

fix(web): prevent multi-select questions from auto-advancing#6443
effektsvk wants to merge 2 commits into
pingdotgg:mainfrom
effektsvk:t3code/fix-multi-select-auto-submit

Conversation

@effektsvk

@effektsvk effektsvk commented Aug 13, 2026

Copy link
Copy Markdown

What Changed

  • Replaced the pending-question option handler’s useEffectEvent with useCallback.
  • Pass the rendered question’s multiSelect value directly to the handler.
  • Cancel pending single-select auto-advance timers when the active question changes or a multi-select option is chosen.
  • Restored the option handler as a dependency of the keyboard shortcut effect.

Why

Multi-select questions could incorrectly auto-advance after selecting an option. This was reproducible with the sequence [single] [multi] [multi], including after navigating back to the first multi-select question.

The option handler was using useEffectEvent as a click handler, which is outside its intended use and could evaluate the selection using stale question state. Passing the current question type explicitly makes the behavior deterministic. Timer cleanup also ensures that a delayed advance belongs only to the single-select question that scheduled it.

UI Changes

No visual styling changes.

Before: selecting an option on a multi-select question could move immediately to the next question.

before-github.mp4

After: multi-select options toggle in place. Only single-select questions auto-advance.

after-github.mp4

Testing

  • Verified with a Claude Sonnet questionnaire containing [single] [multi] [multi].
  • Verified mouse and number-key selection.
  • Verified navigating back from the third question and selecting another option on the second question.
  • 82 focused tests passed.
  • Web typecheck, lint, formatting, and diff checks passed.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • No screenshots required; there are no visual changes
  • I included a video for animation/interaction changes

Note

Low Risk
Localized composer interaction fix with no API or security impact; behavior change is limited to pending user-input option selection.

Overview
Fixes multi-select pending-user-input questions incorrectly auto-advancing to the next question after an option click or number-key shortcut (including when navigating back through a mixed single/multi questionnaire).

Option handling now uses useCallback instead of useEffectEvent, and callers pass the current question’s multiSelect flag so single-select vs multi-select behavior is explicit. Multi-select paths only toggle options and clear any pending advance timer; single-select still schedules the 200ms auto-advance. Timer cleanup runs when the active question id changes (not only on unmount), so a delayed advance cannot fire on the wrong question.

Reviewed by Cursor Bugbot for commit d100f1b. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Prevent multi-select questions from auto-advancing in ComposerPendingUserInputCard

  • Multi-select option toggles now cancel any pending auto-advance timer instead of triggering one, so users can select multiple options without the question advancing prematurely.
  • Single-select behavior is unchanged: selecting an option still auto-advances after ~200ms.
  • Auto-advance timers are also cleared when the active question changes or the component unmounts, preventing stale timers from firing across questions.
  • Replaces useEffectEvent with useCallback in ComposerPendingUserInputPanel.tsx to support passing the multiSelect flag into the option selection handler.

Macroscope summarized d100f1b.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: abfa33ab-fecd-4203-89ff-e03ef572625b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Aug 13, 2026
@github-actions github-actions Bot added the size:M 30-99 changed lines (additions + deletions). label Aug 13, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved d100f1b

Straightforward bug fix with clear intent: prevents multi-select questions from auto-advancing, allowing users to select multiple options before proceeding. Changes are self-contained to a single UI component with no broader impact.

You can customize Macroscope's approvability policy. Learn more.

@shivamhwp

Copy link
Copy Markdown
Collaborator

gpt-5.6-sol on behalf of shivamhwp.

Thank you for fixing the multi-select flow. We are closing this PR because #6646 has already landed the same behavior on main. Multi-select questions now remain open after the first click, and main includes focused tests for that case.

The bug is fixed and tested, so this branch is no longer needed.

@shivamhwp shivamhwp closed this Aug 26, 2026
@effektsvk
effektsvk deleted the t3code/fix-multi-select-auto-submit branch August 26, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants