fix(web): prevent multi-select questions from auto-advancing - #6443
fix(web): prevent multi-select questions from auto-advancing#6443effektsvk wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved d100f1b Straightforward bug fix with clear intent: prevents multi-select questions from auto-advancing, allowing users to select multiple options before proceeding. Changes are self-contained to a single UI component with no broader impact. You can customize Macroscope's approvability policy. Learn more. |
|
gpt-5.6-sol on behalf of shivamhwp. Thank you for fixing the multi-select flow. We are closing this PR because #6646 has already landed the same behavior on main. Multi-select questions now remain open after the first click, and main includes focused tests for that case. The bug is fixed and tested, so this branch is no longer needed. |
What Changed
useEffectEventwithuseCallback.multiSelectvalue directly to the handler.Why
Multi-select questions could incorrectly auto-advance after selecting an option. This was reproducible with the sequence
[single] [multi] [multi], including after navigating back to the first multi-select question.The option handler was using
useEffectEventas a click handler, which is outside its intended use and could evaluate the selection using stale question state. Passing the current question type explicitly makes the behavior deterministic. Timer cleanup also ensures that a delayed advance belongs only to the single-select question that scheduled it.UI Changes
No visual styling changes.
Before: selecting an option on a multi-select question could move immediately to the next question.
before-github.mp4
After: multi-select options toggle in place. Only single-select questions auto-advance.
after-github.mp4
Testing
[single] [multi] [multi].Checklist
Note
Low Risk
Localized composer interaction fix with no API or security impact; behavior change is limited to pending user-input option selection.
Overview
Fixes multi-select pending-user-input questions incorrectly auto-advancing to the next question after an option click or number-key shortcut (including when navigating back through a mixed single/multi questionnaire).
Option handling now uses
useCallbackinstead ofuseEffectEvent, and callers pass the current question’smultiSelectflag so single-select vs multi-select behavior is explicit. Multi-select paths only toggle options and clear any pending advance timer; single-select still schedules the 200ms auto-advance. Timer cleanup runs when the active question id changes (not only on unmount), so a delayed advance cannot fire on the wrong question.Reviewed by Cursor Bugbot for commit d100f1b. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Prevent multi-select questions from auto-advancing in
ComposerPendingUserInputCarduseEffectEventwithuseCallbackin ComposerPendingUserInputPanel.tsx to support passing themultiSelectflag into the option selection handler.Macroscope summarized d100f1b.