fix(web): hide archive confirmation in settings with new sidebar

apps/web/src/components/settings/SettingsPanels.tsx

@@ -2150,31 +2150,33 @@ export function GeneralSettingsPanel() {
           }
         />
 
-        <SettingsRow
-          {...searchableSetting("archive-confirmation")}
-          description="Require a second click on the inline archive action before a thread is archived."
-          resetAction={
-            settings.confirmThreadArchive !== DEFAULT_UNIFIED_SETTINGS.confirmThreadArchive ? (
-              <SettingResetButton
-                label="archive confirmation"
-                onClick={() =>
-                  updateSettings({
-                    confirmThreadArchive: DEFAULT_UNIFIED_SETTINGS.confirmThreadArchive,
-                  })
+        {settings.legacySidebarEnabled ? (
+          <SettingsRow
+            {...searchableSetting("archive-confirmation")}
+            description="Require a second click on the inline archive action before a thread is archived."
+            resetAction={
+              settings.confirmThreadArchive !== DEFAULT_UNIFIED_SETTINGS.confirmThreadArchive ? (
+                <SettingResetButton
+                  label="archive confirmation"
+                  onClick={() =>
+                    updateSettings({
+                      confirmThreadArchive: DEFAULT_UNIFIED_SETTINGS.confirmThreadArchive,
+                    })
+                  }
+                />
+              ) : null
+            }
+            control={
+              <Switch
+                checked={settings.confirmThreadArchive}
+                onCheckedChange={(checked) =>
+                  updateSettings({ confirmThreadArchive: Boolean(checked) })
                 }
+                aria-label="Confirm thread archiving"
               />
-            ) : null
-          }
-          control={
-            <Switch
-              checked={settings.confirmThreadArchive}
-              onCheckedChange={(checked) =>
-                updateSettings({ confirmThreadArchive: Boolean(checked) })
-              }
-              aria-label="Confirm thread archiving"
-            />
-          }
-        />
+            }
+          />
+        ) : null}
 
         <SettingsRow
           {...searchableSetting("delete-confirmation")}

apps/web/src/components/settings/SettingsSidebarNav.tsx

@@ -34,12 +34,14 @@ import {
   useSidebar,
 } from "../ui/sidebar";
 import { T3ConnectSidebarAvatar, T3ConnectSidebarSignIn } from "../clerk/T3ConnectSidebarSignIn";
+import { useLegacySidebarEnabled } from "../../hooks/useSettings";
 import { scrollToSettingsTarget } from "./settingsLayout";
 import {
   searchSettings,
   SETTINGS_SECTION_LABELS,
   type SettingsPath,
   type SettingsSearchItem,
+  visibleSettingsSearchItems,
 } from "./settingsSearch";
 
 const SETTINGS_SECTION_ICONS: Readonly<
@@ -77,7 +79,11 @@ export function SettingsSidebarNav({ pathname }: { pathname: string }) {
   const searchInputRef = useRef<HTMLInputElement>(null);
   const [query, setQuery] = useState("");
   const [activeResultIndex, setActiveResultIndex] = useState(0);
-  const results = useMemo(() => searchSettings(query), [query]);
+  const legacySidebarEnabled = useLegacySidebarEnabled();
+  const results = useMemo(
+    () => searchSettings(query, visibleSettingsSearchItems(legacySidebarEnabled)),
+    [legacySidebarEnabled, query],
+  );
   const isSearching = query.trim().length > 0;
   const hasResults = results.length > 0;
 

apps/web/src/components/settings/settingsSearch.test.ts

@@ -5,6 +5,7 @@ import {
   searchSettings,
   SETTINGS_SEARCH_ITEMS,
   type SettingsSearchItem,
+  visibleSettingsSearchItems,
 } from "./settingsSearch";
 
 const ITEMS: ReadonlyArray<SettingsSearchItem> = [
@@ -65,6 +66,15 @@ describe("searchSettings", () => {
     expect(new Set(ids).size).toBe(ids.length);
   });
 
+  it("only exposes archive confirmation for the legacy sidebar", () => {
+    expect(
+      visibleSettingsSearchItems(false).some((item) => item.id === "archive-confirmation"),
+    ).toBe(false);
+    expect(
+      visibleSettingsSearchItems(true).some((item) => item.id === "archive-confirmation"),
+    ).toBe(true);
+  });
+
   it("serves anchor props to panels from the catalog", () => {
     expect(searchableSetting("word-wrap")).toEqual({ id: "word-wrap", title: "Word wrap" });
     expect(searchableSetting("archive")).toEqual({ id: "archive", title: "Archived threads" });

apps/web/src/components/settings/settingsSearch.ts

@@ -12,6 +12,7 @@ export interface SettingsSearchItem {
   readonly title: string;
   readonly to: SettingsPath;
   readonly targetId?: string;
+  readonly requiresLegacySidebar?: boolean;
 }
 
 /**
@@ -138,6 +139,7 @@ export const SETTINGS_SEARCH_ITEMS = [
     id: "archive-confirmation",
     title: "Archive confirmation",
     to: "/settings/general",
+    requiresLegacySidebar: true,
   },
   {
     id: "delete-confirmation",
@@ -233,3 +235,11 @@ export function searchSettings(
 
   return items.filter((item) => normalizeSearchText(item.title).includes(normalizedQuery));
 }
+
+export function visibleSettingsSearchItems(
+  legacySidebarEnabled: boolean,
+  items: ReadonlyArray<SettingsSearchItem> = SETTINGS_SEARCH_ITEMS,
+): ReadonlyArray<SettingsSearchItem> {
+  if (legacySidebarEnabled) return items;
+  return items.filter((item) => item.requiresLegacySidebar !== true);
+}