Repository navigation
Add hourly past-24-hour usage view - #6170
Effect Service Conventions: All clear
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
🔍 Agent activity — reasoning, no tool calls
💭 Looking at the convention for error construction in UsageService.ts — the new detail fields with static messages like "Hourly usage requires valid sinceTime and untilTime instants" seem to follow the existing pattern of including contextual information, though I'm wondering if these hardcoded strings align with the "stable, serializable domain context" principle or if they should be parameterized like the current sinceDay/untilDay interpolations.… Looking at the service violations and imports across the changed files — UsageService doesn't introduce any new Effect service definitions, just uses namespace imports which is fine. The test layer with
Layer.succeedis pre-existing. The imports from@t3tools/contractsand@t3tools/shared/usageFormatare all named imports for pure helpers, which are allowed. The new error details in UsageService are static strings following the convention for bounded descriptions, so that checks out. Now I need to verify the aggregation file more carefully to make sure there's nothing else I'm missing.…
Agent Credits: 59 credits