Skip to content

fix(server): soften Codex CLI version enforcement - #609

Closed
binbandit wants to merge 4 commits into
pingdotgg:mainfrom
binbandit:fix/codex-version-check-warning
Closed

fix(server): soften Codex CLI version enforcement#609
binbandit wants to merge 4 commits into
pingdotgg:mainfrom
binbandit:fix/codex-version-check-warning

Conversation

@binbandit

@binbandit binbandit commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the hard codex --version startup gate added in 0.0.5 that blocks sessions for any parsable Codex version below 0.37.0.
  • Keep the minimum-version check as a provider health warning so users still get compatibility guidance without losing access to working internal Codex forks.

Closes #604

Why

Issue #604 reports a real regression from 0.0.4 -> 0.0.5: internal/company Codex builds can report a different version number than the open-source CLI, and 0.0.5 started hard-failing session startup before even attempting codex app-server.

I validated the regression in the code:

That is too strict for enterprise forks where version numbers diverge but runtime compatibility can still be fine.

Changes

  • apps/server/src/codexAppServerManager.ts
    • remove the synchronous startup-time version gate
    • let codex app-server be the source of truth for whether the provider can actually start
  • apps/server/src/provider/Layers/ProviderHealth.ts
    • keep the minimum-version check, but downgrade it to a warning when auth is otherwise healthy
    • preserve the existing warning message so users still see compatibility guidance
  • tests updated accordingly

Validation

Passed:

  • bun lint
  • bun typecheck
  • bun run test src/codexAppServerManager.test.ts in apps/server
  • bun run test src/provider/Layers/ProviderHealth.test.ts in apps/server

Repo baseline issue still present:

  • full bun run test still fails on pre-existing unrelated web storage test regressions in apps/web/src/terminalStateStore.test.ts and apps/web/src/composerDraftStore.test.ts

Note

Downgrade Codex CLI version enforcement from error to warning in provider health checks

  • Removes the pre-launch version check from CodexAppServerManager.startSession, so an unsupported CLI version no longer causes startFailed before the process spawns.
  • Changes checkCodexProviderStatus in ProviderHealth.ts to return status: 'warning' (available: true) instead of status: 'error' (available: false) when the CLI is below the minimum supported version.
  • Auth command timeouts now also return 'warning' instead of 'error'.
  • Behavioral Change: users on unsupported Codex CLI versions will see a warning rather than a hard error, and the server session will proceed.

Macroscope summarized 82c37ad.

T3 Code 0.0.5 regressed enterprise and internal Codex builds by hard
blocking session startup whenever codex-cli 0.111.0 reported a parsable
version below the open-source minimum, even if the CLI still worked.

Remove the synchronous startup gate and keep the minimum-version check as
a provider-health warning instead, so users still see compatibility
feedback without losing access to working internal Codex forks.

Closes pingdotgg#604
@coderabbitai

coderabbitai Bot commented Mar 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2b0bda66-5502-4139-8efc-5bc0f56291aa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Mar 9, 2026
@binbandit

Copy link
Copy Markdown
Contributor Author

@juliusmarminge this one is an easy fix for orgs who roll their own codex -- will help a lot of people

@Noojuno

Noojuno commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

@binbandit If we're moving it to a warning, I think we should move the version to 0.99.0 to help with #736. The --ephemeral flag used for generating commit messages requires 0.99.0

@Da1sypetals

Copy link
Copy Markdown

Want this feature very bad 😢 thanks!

@Da1sypetals

Copy link
Copy Markdown

😢 Anyone on this

@binbandit

Copy link
Copy Markdown
Contributor Author

😢 Anyone on this

Dont worry, i'm still on this. Just got lots of other PR's to be across too

…heck-warning

# Conflicts:
#	apps/server/src/provider/Layers/ProviderHealth.test.ts
@github-actions github-actions Bot added the size:L 100-499 changed lines (additions + deletions). label Mar 13, 2026
@Da1sypetals

Copy link
Copy Markdown

Plz also do this for claude code, we also use a enterprise encapsulation of claude-code

Appreciate your work! ❤️ ❤️

@binbandit

Copy link
Copy Markdown
Contributor Author

Plz also do this for claude code, we also use a enterprise encapsulation of claude-code

Appreciate your work! ❤️ ❤️

Reach out on discord, let me see exactly what you guys are doing so i can better tailor this.

._0siris_.

@maria-rcks maria-rcks closed this Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version check

4 participants