Skip to content

Fix for issue 4507 - #6054

Closed
mohamedmastouri-hue wants to merge 1 commit into
pingdotgg:mainfrom
mohamedmastouri-hue:fix-4507
Closed

Fix for issue 4507#6054
mohamedmastouri-hue wants to merge 1 commit into
pingdotgg:mainfrom
mohamedmastouri-hue:fix-4507

Conversation

@mohamedmastouri-hue

@mohamedmastouri-hue mohamedmastouri-hue commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Fixes issue #4507


Note

Low Risk
Test-only changes in ClaudeTextGeneration.test.ts with no production runtime impact.

Overview
Makes the Claude text generation test harness run on Windows by replacing the POSIX shell fake claude executable with a Node script that preserves the same env-driven assertions (args, stdin, CLAUDE_CONFIG_DIR, stderr, exit code, stdout).

On win32, the helper now also writes claude.cmd so resolution via PATH can invoke the fake CLI the way Windows expects. PATH prepending uses node:path’s delimiter instead of a hardcoded :.

Reviewed by Cursor Bugbot for commit 7e0ccc1. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix fake Claude binary test util to run on Windows

  • Replaces the POSIX shell fake claude binary with a Node.js script (via #!/usr/bin/env node) that reads argv and stdin using Node APIs, so it runs cross-platform.
  • On Windows, writes a claude.cmd shim that delegates to the Node script, making the binary discoverable via PATH.
  • Fixes PATH construction in withFakeClaudeEnv to use nodePath.delimiter instead of a hardcoded :.

Macroscope summarized 7e0ccc1.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 71dfa9fd-7310-46cb-95cc-8a982af86310

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 10, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 7e0ccc1

Test-only changes that convert a shell script-based test fixture to Node.js for Windows compatibility. No production code is affected, and the cross-platform fixes (using nodePath.delimiter, adding Windows .cmd wrapper) are straightforward.

You can customize Macroscope's approvability policy. Learn more.

@t3dotgg

t3dotgg commented Aug 28, 2026

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

The hermetic Claude command fixture in this test-only branch already landed in #4508. Main has the Node stub, Windows command wrapper, and host-specific path delimiter, so this branch has no unique test behavior left.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotgg t3dotgg closed this Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants