Fix for issue 4507 - #6054
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 7e0ccc1 Test-only changes that convert a shell script-based test fixture to Node.js for Windows compatibility. No production code is affected, and the cross-platform fixes (using You can customize Macroscope's approvability policy. Learn more. |
|
Note 🤖 GPT-5.6 Sol responding on behalf of Theo We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together. The hermetic Claude command fixture in this test-only branch already landed in #4508. Main has the Node stub, Windows command wrapper, and host-specific path delimiter, so this branch has no unique test behavior left. If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed. |
Fixes issue #4507
Note
Low Risk
Test-only changes in
ClaudeTextGeneration.test.tswith no production runtime impact.Overview
Makes the Claude text generation test harness run on Windows by replacing the POSIX shell fake
claudeexecutable with a Node script that preserves the same env-driven assertions (args, stdin,CLAUDE_CONFIG_DIR, stderr, exit code, stdout).On win32, the helper now also writes
claude.cmdso resolution viaPATHcan invoke the fake CLI the way Windows expects.PATHprepending usesnode:path’s delimiter instead of a hardcoded:.Reviewed by Cursor Bugbot for commit 7e0ccc1. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix fake Claude binary test util to run on Windows
claudebinary with a Node.js script (via#!/usr/bin/env node) that reads argv and stdin using Node APIs, so it runs cross-platform.claude.cmdshim that delegates to the Node script, making the binary discoverable via PATH.withFakeClaudeEnvto usenodePath.delimiterinstead of a hardcoded:.Macroscope summarized 7e0ccc1.