Repository navigation
Add settings and usage breadcrumbs #5929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9ff6bd8
feat(web): add settings and usage breadcrumbs
juliusmarminge 4dc25fe
refactor(web): compose workspace breadcrumbs from reusable items
juliusmarminge 4d32c0d
fix(web): keep usage breadcrumb items as spans
juliusmarminge 4fb10d0
fix(web): use semantic breadcrumbs in settings
juliusmarminge 23a8c47
fix(web): improve project settings breadcrumbs
juliusmarminge 6e42fda
fix(web): correct chat breadcrumb flex classes
juliusmarminge d21a4e2
refactor(web): simplify project menu callback
juliusmarminge 911a02c
Delete apps/web/src/components/WorkspaceBreadcrumb.test.tsx
juliusmarminge 59221e3
Delete apps/web/src/components/settings/SettingsBreadcrumb.test.tsx
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { renderToStaticMarkup } from "react-dom/server"; | ||
| import { describe, expect, it } from "vite-plus/test"; | ||
|
|
||
| import { | ||
| WorkspaceBreadcrumb, | ||
| WorkspaceBreadcrumbItem, | ||
| WorkspaceBreadcrumbSeparator, | ||
| } from "./WorkspaceBreadcrumb"; | ||
|
|
||
| describe("WorkspaceBreadcrumb", () => { | ||
| it("composes plain text and custom children", () => { | ||
| const markup = renderToStaticMarkup( | ||
| <WorkspaceBreadcrumb ariaLabel="Project breadcrumb"> | ||
| <WorkspaceBreadcrumbItem>Projects</WorkspaceBreadcrumbItem> | ||
| <WorkspaceBreadcrumbSeparator /> | ||
| <WorkspaceBreadcrumbItem current> | ||
| <button type="button">Switch project</button> | ||
| </WorkspaceBreadcrumbItem> | ||
| </WorkspaceBreadcrumb>, | ||
| ); | ||
|
|
||
| expect(markup).toContain('aria-label="Project breadcrumb"'); | ||
| expect(markup).toContain("Projects"); | ||
| expect(markup).toContain(">/</span>"); | ||
| expect(markup).toContain('aria-current="page"'); | ||
| expect(markup).toContain('<button type="button">Switch project</button>'); | ||
| }); | ||
|
|
||
| it("can preserve a page heading for a plain-text breadcrumb", () => { | ||
| const markup = renderToStaticMarkup( | ||
| <WorkspaceBreadcrumb ariaLabel="Usage breadcrumb"> | ||
| <WorkspaceBreadcrumbItem as="h1" current> | ||
| Usage | ||
| </WorkspaceBreadcrumbItem> | ||
| </WorkspaceBreadcrumb>, | ||
| ); | ||
|
|
||
| expect(markup).toContain('<h1 aria-current="page"'); | ||
| expect(markup).toContain(">Usage</h1>"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import type { ReactNode } from "react"; | ||
|
|
||
| import { cn } from "../lib/utils"; | ||
|
|
||
| interface WorkspaceBreadcrumbProps { | ||
| readonly ariaLabel: string; | ||
| readonly children: ReactNode; | ||
| readonly className?: string; | ||
| } | ||
|
|
||
| export function WorkspaceBreadcrumb({ ariaLabel, children, className }: WorkspaceBreadcrumbProps) { | ||
| return ( | ||
| <nav | ||
| aria-label={ariaLabel} | ||
| className={cn( | ||
| "flex min-w-0 items-center gap-2 overflow-hidden [-webkit-app-region:no-drag] sm:gap-3", | ||
| className, | ||
| )} | ||
| > | ||
| {children} | ||
| </nav> | ||
| ); | ||
| } | ||
|
|
||
| interface WorkspaceBreadcrumbItemProps { | ||
| readonly as?: "h1" | "span"; | ||
| readonly children: ReactNode; | ||
| readonly className?: string; | ||
| readonly current?: boolean; | ||
| } | ||
|
|
||
| export function WorkspaceBreadcrumbItem({ | ||
| as: Component = "span", | ||
| children, | ||
| className, | ||
| current = false, | ||
| }: WorkspaceBreadcrumbItemProps) { | ||
| return ( | ||
| <Component | ||
| aria-current={current ? "page" : undefined} | ||
| className={cn( | ||
| "min-w-0 text-sm font-medium", | ||
| current ? "text-foreground" : "shrink-0 text-muted-foreground", | ||
| className, | ||
| )} | ||
| > | ||
| {children} | ||
| </Component> | ||
| ); | ||
| } | ||
|
|
||
| export function WorkspaceBreadcrumbSeparator() { | ||
| return ( | ||
| <span aria-hidden="true" className="shrink-0 text-icon-muted"> | ||
| / | ||
| </span> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.