Skip to content

fix(desktop): skip the PowerShell profile probe when node is already resolvable - #5771

Closed
CDVolvik wants to merge 1 commit into
pingdotgg:mainfrom
CDVolvik:fix/windows-skip-profile-probe-when-node-resolvable
Closed

CDVolvik wants to merge 1 commit into
pingdotgg:mainfrom
CDVolvik:fix/windows-skip-profile-probe-when-node-resolvable

fix(desktop): skip the PowerShell profile probe when node is already …

ccb618c
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Aug 9, 2026 in 1m 31s

All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — reasoning, no tool calls

💭 I'm reviewing the import conventions for this module. The question is whether to use a named import or namespace import for CommandAvailability from the shell package subpath. Since this is a utility module rather than a service module, and we're only importing a single tag, a named import seems more appropriate here. Looking at the test setup, providing the service as a layer seam is legitimate. The redundancy of yielding CommandAvailability and then re-providing it with Effect.provideService is harmless but worth noting — since it has a default value, this pattern works but could potentially be streamlined. The named import pattern aligns with the repo's conventions for this shared utilities module. CommandAvailability is a Context.Reference that returns an Effect requiring FileSystem and Path dependencies, so using yield* CommandAvailability correctly acquires it from the environment. Providing the service with Effect.provideService(CommandAvailability, commandAvailable) follows the expected pattern, and the test setup appears to be using Layer.succe


Agent Credits: 83 credits