Skip to content

fix(server): stop Claude resume handshakes from completing turns that never ran - #5710

Merged
t3dotgg merged 3 commits into
pingdotgg:mainfrom
gfsaaser24:t3code/upstream-phantom-turn-fix
Aug 9, 2026
Merged

t3dotgg merged 3 commits into
pingdotgg:mainfrom
gfsaaser24:t3code/upstream-phantom-turn-fix

fix(server): keep the new ingestion tests under the manual-runtime ra…

e670eb0
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Aug 8, 2026 in 37s

All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — reasoning, no tool calls

💭 The imports are fine I'm weighing whether including the provider's error message in the log violates the convention against copying raw wire payloads. Since the code already emits raw payloads to events elsewhere and this is a diagnostic log rather than an error attribute, it seems acceptable to include. Now I'm checking the ProviderRuntimeIngestion.ts changes — the behavior modification has tests, which is good. The Effect service usage looks fine: Effect.runPromise in tests is acceptable, and Effect.forkChild is appropriate. The test harness dispatch function also uses Effect.runPromise correctly. I don't see any ManagedRuntime.make or service-instance parameters being added, just the two production edits and tests. The log uses Effect.logInfo with an object argument, which is correct for Effect v4. Since backend behavior is changing, the focused tests satisfy that convention requirement.


Agent Credits: 32 credits