Skip to content

fix(server): advertise 256-color TERM on Windows terminals #5693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 3 commits into from
Aug 11, 2026
Merged

fix(server): advertise 256-color TERM on Windows terminals #5693

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b167e17
fix(server): advertise 256-color TERM on Windows terminals
yassiEmp Aug 8, 2026
3918ce3
fix(server): set TERM in the Windows spawn env, not only the pty name
yassiEmp Aug 8, 2026
5c86c88
test(server): cover the Windows TERM spawn-env default
yassiEmp Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/server/src/terminal/NodePtyAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export const make = Effect.fn("NodePtyAdapter.make")(function* (
cols: input.cols,
rows: input.rows,
env: input.env,
name: platform === "win32" ? "xterm-color" : "xterm-256color",
name: "xterm-256color",
Comment thread
cursor[bot] marked this conversation as resolved.
Comment on lines +144 to +158

@macroscopeapp macroscopeapp Bot Aug 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes backend spawn behavior on win32, but apps/server/src/terminal/NodePtyAdapter.test.ts still asserts the old call shape (env: {} and name: "xterm-color" with HostProcessPlatform set to win32), so it will fail. Consider updating that assertion to env: { TERM: "xterm-256color" } / name: "xterm-256color", and adding a focused case that an explicitly provided TERM in input.env is preserved.

Posted via Macroscope — Effect Service Conventions

@yassiEmp yassiEmp Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 5c86c88: assertion updated to the new call shape, plus a focused case that a caller-provided TERM is preserved.

@macroscopeapp macroscopeapp Bot Aug 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

}),
catch: (cause) =>
new PtyAdapter.PtySpawnError({
Expand Down
Loading