Skip to content

fix(vcs): surface git's stderr on GitCommandError - #5620

Closed
IAmJSD wants to merge 7 commits into
pingdotgg:mainfrom
Infrawrench:surface-git-stderr
Closed

IAmJSD wants to merge 7 commits into
pingdotgg:mainfrom
Infrawrench:surface-git-stderr

fix(vcs): classify not-found before access-rights, stabilize locale

dc88184
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Aug 10, 2026 in 8m 6s

Approved (click on check for details)

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
This PR improves git error classification and messaging without changing core git operation behavior. The schema change is additive (optional failureKind field), tests are extensive, and the implementation is security-conscious by avoiding leaking stderr content in error messages.

Notes:
No code owners found in target merge base 9821bca