Skip to content

feat(grok): multi-agent visibility via task.* events - #5425

Closed
EnzoTironi wants to merge 5 commits into
pingdotgg:mainfrom
EnzoTironi:pr/grok-multiagent
Closed

EnzoTironi wants to merge 5 commits into
pingdotgg:mainfrom
EnzoTironi:pr/grok-multiagent

fix(grok): set_model effort, plan capture, compact, review findings

3929597
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Aug 5, 2026 in 1m 14s

Effect Service Conventions: no issues found

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — reasoning, no tool calls

💭 Looking at the key files to understand the code conventions being used, particularly how imports from the "effect" library are structured and whether they're using consolidated named imports or individual imports. Checking for new Context.Service definitions, error handling patterns like Schema.TaggedErrorClass, and how Effect.catch is being used — it looks like they're catching errors intentionally in some places like GrokAdapter. Also examining how PubSub and other effect utilities are being acquired and released, and whether type imports are being mixed with value imports correctly. Now I'm looking at GrokAcpSupport to see if the service injection pattern is being followed correctly, particularly with how applyGrokAcpConfigSelections accepts a Pick type from the runtime service. I'm checking whether the ProviderDriverError construction violates the convention about not copying cause.message into a detail field—looking at the diff to see if this pattern was introduced in the PR or already existed. I'm noticing an import statement for GrokAdapterShape that predates this change, and I need to figure out whether it violates the naming convention that says to use Foo["Service"] instead of a standalone FooShape. Since the file is being touched but this particular line isn't modified, I'm checking whether the instructions about reporting violations apply to pre-existing code or only to newly introduced changes. Looking at the actual new code being added — the GrokAdapter token usage and session context patterns are following existing conventions in the codebase. The GrokProvider exports pure helper functions, XAiAcpExtension defines schemas and utility functions without convention issues, and AcpSessionRuntime is adding optional parameters to its Context.Service interface which is fine. I'm now examining the GrokAcpSupport changes to see if there are any actual violations being introduced. The exports are mostly consistent with conventions, though I notice isGrokEnterPlanModeToolCall is exported from the adapter file while its sibling isGrokSubagentToolCall lives in GrokAcpSupport.ts, which breaks the pattern. I'm also checking whether Effect.catch with logging is acceptable here—it looks like it should be fine based on the guidelines. Now I'm verifying the CursorAdapter and AcpCoreRuntimeEvents changes are pure functions, and reviewing the GrokTextGeneration modification to the selections field. I need to look at the AcpSessionRuntime service definition to make sure it wasn't restructured in ways that violate the conventions. Looking at the GrokTextGeneration.ts change where selections is set to modelSelection.options — I need to verify the context doesn't introduce any unexpected behavior. Also reviewing the new authFailure regex in GrokProvider.ts that uses String(discoveryExit.cause) for status message classification rather than error construction, which aligns with the convention of using static strings in messages rather than copying raw cause text. I'm confident there are no issues here. Now I'm resolving the response format: the customer wants the final answer as exactly "All clear" on one line, but the schema requires JSON output. I'll structure this as a success state with the summary set to "All clear" to satisfy both the schema requirement and the instruction intent.


Agent Credits: 90 credits