Skip to content

fix(shared): detect Azure DevOps SSH remotes #5273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Brechard wants to merge 11 commits into from
Closed

fix(shared): detect Azure DevOps SSH remotes #5273

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2e99448
fix(shared): detect Azure DevOps SSH remotes
rodrigoB-CB Aug 3, 2026
4cbde3b
fix(server): pass Azure repository context for SSH PRs
rodrigoB-CB Aug 3, 2026
0eab33e
fix(desktop): inherit Azure DevOps auth from login shell
rodrigoB-CB Aug 3, 2026
dad8d99
test(server): use neutral Azure DevOps fixtures
rodrigoB-CB Aug 3, 2026
c665bcb
docs(server): document Azure DevOps helpers
rodrigoB-CB Aug 4, 2026
7e69451
fix(server): preserve Azure context across PR operations
rodrigoB-CB Aug 4, 2026
595ca4d
fix(server): handle Azure DevOps fork PR checkouts
rodrigoB-CB Aug 4, 2026
43cd1cd
fix(server): identify Azure checkout failure stage
rodrigoB-CB Aug 4, 2026
a34e2e7
fix(server): preserve Azure fork checkout transport
rodrigoB-CB Aug 4, 2026
545281d
fix(server): preserve Azure fork identity
rodrigoB-CB Aug 4, 2026
f103a6a
fix(server): resolve qualified Azure repositories
rodrigoB-CB Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/desktop/src/shell/DesktopShellEnvironment.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ describe("DesktopShellEnvironment", () => {
PATH: "/opt/homebrew/bin:/usr/bin",
SSH_AUTH_SOCK: "/tmp/secretive.sock",
HOMEBREW_PREFIX: "/opt/homebrew",
AZURE_DEVOPS_EXT_PAT: "pat-from-login-shell",
});
},
});
Expand All @@ -126,6 +127,7 @@ describe("DesktopShellEnvironment", () => {
assert.equal(env.PATH, "/opt/homebrew/bin:/usr/bin:/Users/test/.local/bin");
assert.equal(env.SSH_AUTH_SOCK, "/tmp/secretive.sock");
assert.equal(env.HOMEBREW_PREFIX, "/opt/homebrew");
assert.equal(env.AZURE_DEVOPS_EXT_PAT, "pat-from-login-shell");
}),
);

Expand All @@ -135,6 +137,7 @@ describe("DesktopShellEnvironment", () => {
SHELL: "/bin/zsh",
PATH: "/usr/bin",
SSH_AUTH_SOCK: "/tmp/inherited.sock",
AZURE_DEVOPS_EXT_PAT: "inherited-pat",
};

yield* runShellEnvironment({
Expand All @@ -144,11 +147,13 @@ describe("DesktopShellEnvironment", () => {
envOutput({
PATH: "/opt/homebrew/bin:/usr/bin",
SSH_AUTH_SOCK: "/tmp/login-shell.sock",
AZURE_DEVOPS_EXT_PAT: "pat-from-login-shell",
}),
});

assert.equal(env.PATH, "/opt/homebrew/bin:/usr/bin");
assert.equal(env.SSH_AUTH_SOCK, "/tmp/inherited.sock");
assert.equal(env.AZURE_DEVOPS_EXT_PAT, "inherited-pat");
}),
);

Expand Down
4 changes: 4 additions & 0 deletions apps/desktop/src/shell/DesktopShellEnvironment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ const LOGIN_SHELL_ENV_NAMES = [
"XDG_CONFIG_HOME",
"XDG_CURRENT_DESKTOP",
"XDG_DATA_HOME",
// Azure DevOps CLI commonly receives its PAT from the user's login shell.
// Keep it available when the desktop app is launched outside a terminal.
"AZURE_DEVOPS_EXT_PAT",
"XDG_RUNTIME_DIR",
"XDG_SESSION_DESKTOP",
"XDG_SESSION_TYPE",
Expand Down Expand Up @@ -456,6 +459,7 @@ const installPosixEnvironment = Effect.fn("desktop.shellEnvironment.installPosix
"HOMEBREW_REPOSITORY",
"XDG_CONFIG_HOME",
"XDG_DATA_HOME",
"AZURE_DEVOPS_EXT_PAT",
"XDG_RUNTIME_DIR",
"WAYLAND_DISPLAY",
] as const) {
Expand Down
Loading
Loading