Skip to content

fix(shared): lenient JSON parser deletes commas inside string values - #5025

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
arhxam:fix/lenient-json-preserve-commas-in-strings
Jul 30, 2026
Merged

fix(shared): lenient JSON parser deletes commas inside string values#5025
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
arhxam:fix/lenient-json-preserve-commas-in-strings

fix(shared): stop the lenient JSON parser from deleting commas inside…

db304b2
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Jul 30, 2026 in 20s

All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — reasoning, no tool calls

💭 I'm examining the changed file to understand what's being modified—it looks like a regex update in schemaJson.ts along with a corresponding test. Let me verify whether this is actually an Effect service or just a utility function, and check if the implementation follows the right conventions. This is a helper change with no Effect service involved, and the imports already follow the subpath conventions correctly. But I'm noticing a conflict—the instructions say to respond with just "All clear" on one line, yet the system requires JSON output. The check defaults to failure, but when there are no findings, it should return success with "All clear" as the response, so I'll structure that as the title and summary in the JSON.


Agent Credits: 22 credits