Skip to content

fix(server): stop replayed history from re-arming mouse reporting - #4821

Closed
Sy-D wants to merge 3 commits into
pingdotgg:mainfrom
Sy-D:fix/terminal-replay-mouse-mode
Closed

Sy-D wants to merge 3 commits into
pingdotgg:mainfrom
Sy-D:fix/terminal-replay-mouse-mode

fix(server): treat X10 as a mouse tracking mode

add5fa2
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Jul 29, 2026 in 10s

Effect Service Conventions: no issues found

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.


🔍 Agent activity — reasoning, no tool calls

💭 Looking at the diff for the Manager.ts file, I see a new pure helper function replaySafeTerminalHistory was added along with a module-level regex that uses mutable state through lastIndex. This isn't really an Effect service convention issue since the exported function itself isn't hiding dependencies in a problematic way, though the stateful regex is worth noting. Let me check what tests were added to understand the scope better. Now checking the test file imports. The Effect service conventions look clean—imports are properly namespaced and the tests are legitimately focused on behavior changes. The regex global-state is a potential correctness issue, though it's not flagged by the convention checks. Now I need to verify how pollSubprocessActivity is being called to make sure it's not relying on something like runPromise. There's a tension between the instruction to return "All clear" as plain text and the schema requirement for JSON format. The schema takes precedence, so I'll structure the response as JSON with a success state and set the title and summary fields to indicate no violations were found.