-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Fix draft banner stack overlap #4164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ea80fe4
Fix draft banner stack overlap
juliusmarminge 01aca05
Reduce draft headline size to prevent overlap
juliusmarminge 90ee1f2
Fix composer banner overlap with draft input
juliusmarminge 0507e3c
Merge branch 'main' into t3code/fix-banner-draft-overlap
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import { renderToStaticMarkup } from "react-dom/server"; | ||
| import { describe, expect, it } from "vite-plus/test"; | ||
|
|
||
| import { ComposerBannerStack, type ComposerBannerStackItem } from "./ComposerBannerStack"; | ||
|
|
||
| const banner = (id: string): ComposerBannerStackItem => ({ | ||
| id, | ||
| variant: "warning", | ||
| icon: <span aria-hidden="true">!</span>, | ||
| title: `${id} warning`, | ||
| }); | ||
|
|
||
| describe("ComposerBannerStack", () => { | ||
| it("keeps expanded banners in layout flow so surrounding content moves out of their way", () => { | ||
| const markup = renderToStaticMarkup( | ||
| <ComposerBannerStack items={[banner("front"), banner("stacked")]} />, | ||
| ); | ||
|
|
||
| const expandedItems = markup.match( | ||
| /<div data-composer-banner-stack-expanded-items="true" class="([^"]+)">/, | ||
| ); | ||
|
|
||
| expect(expandedItems?.[1]).toContain("grid-rows-[0fr]"); | ||
| expect(expandedItems?.[1]).toContain("group-hover/banner-stack:grid-rows-[1fr]"); | ||
| expect(expandedItems?.[1]).not.toContain("absolute"); | ||
| expect(markup.indexOf("stacked warning")).toBeLessThan(markup.indexOf("front warning")); | ||
| }); | ||
|
|
||
| it("does not render an expandable region for a single banner", () => { | ||
| const markup = renderToStaticMarkup(<ComposerBannerStack items={[banner("front")]} />); | ||
|
|
||
| expect(markup).not.toContain("data-composer-banner-stack-expanded-items"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stacked dismiss animation clipped
Low Severity
Stacked composer banners dismiss with a large downward
translate3d, but those alerts now sit inside the grid collapse wrapper that usesmin-h-0 overflow-hidden. Transforms do not expand that box, so the exit motion is cut off while opacity fades. The version-mismatch dismiss looks broken compared with the front banner, which is not inside that clip.Reviewed by Cursor Bugbot for commit 0507e3c. Configure here.