Repository navigation
[codex] Preserve cloud disconnect diagnostics - #3437
Merged
Merged
MacroscopeApp / Macroscope - Effect Service Conventions
succeeded
Jun 20, 2026 in 52s
Effect Service Conventions: All clear
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed the two changed files in scope (apps/server/src/cli/connect.ts, apps/server/src/cli/connect.test.ts) against the Effect service conventions.
- Imports: All Effect modules are imported as namespaces from their subpaths (
import * as Cause from "effect/Cause",Console,Exit,Logger,References).@t3tools/contractskeeps a named import, and@effect/vitestuses named test imports — both consistent with the guidance. No consolidated"effect"named imports. - Service definition: No service tag/
make/layeris created, moved, or refactored here; the change extracts a reporting helper (reportCloudDisconnectResults) and a logging helper. No standalone shape types or compatibility shims introduced. - Errors/discriminators:
CloudDisconnectOperation(live-server-unlink|relay-environment-unlink) is used only forEffect.annotateLogsdiagnostics, not to choose user-facing messages or drive control flow, so it is allowed to remain a field. TheLiveCloudActionResult.causetype tightening fromunknowntoCause.Cause<unknown>is an improvement and preserves the real cause viaCause.prettyin structured logs. - Behavior change & tests: The change moves diagnostic causes out of user-facing console warnings into structured logs — a genuine backend behavior change. The added test verifies this behavior directly (causes appear in log annotations, not in console warnings), which is the focused test the conventions call for rather than a redundant refactor-only test.
No convention violations found in the changed scope.
The agent made no additional tool calls beyond your initial Check Run Agent prompt.
Agent Credits: 33 credits
Loading