[codex] sanitize VCS refresh diagnostics - #3416
Merged
juliusmarminge merged 1 commit intoJun 20, 2026
Merged
juliusmarminge merged 1 commit into
juliusmarminge merged 1 commit into
MacroscopeApp / Macroscope - Effect Service Conventions
succeeded
Jun 20, 2026 in 53s
Effect service review: All clear
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed the changed files in scope (apps/server/src/vcs/VcsStatusBroadcaster.ts and apps/server/src/vcs/VcsStatusBroadcaster.test.ts) against the Effect service conventions.
Findings:
- Imports: All Effect library modules are imported as namespaces from their subpaths (
import * as Cause from "effect/Cause",import * as Logger from "effect/Logger", etc.). The local service module is imported as a namespace (import * as VcsStatusBroadcaster from "./VcsStatusBroadcaster.ts") andGitManagerErroris a named import from the whole@t3tools/contractspackage, which is allowed. No consolidated named imports from"effect". - Service definition: The
Context.Servicetag, inline interface,make, andlayerare unchanged and remain canonical; the new code only adds pure module-level helpers (remoteRefreshFailureDiagnosticsand friends), which is appropriate and not a service shape concern. - Errors: No new error class is introduced. The change replaces caller-visible
cwd/detail: exit.cause.toString()log fields with redacted structural diagnostics (counts, tags, operations, bounded values) and forwards interruption causes viaEffect.failCause.GitManagerErroritself is defined in@t3tools/contractsand is not modified here. - Change discipline: This is a behavioral change (log redaction / interruption propagation), and the added focused tests cover it directly rather than padding a mechanical refactor.
No convention violations were introduced or retained in the changed scope.
The agent made no additional tool calls beyond your initial Check Run Agent prompt.
Agent Credits: 34 credits
Loading