[codex] Structure native view resolution failures - #3353
Merged
Merged
MacroscopeApp / Macroscope - Effect Service Conventions
succeeded
Jun 20, 2026 in 37s
Effect Service Conventions: All clear
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed the changed TypeScript in scope:
apps/mobile/src/native/nativeViewResolutionError.ts(new)apps/mobile/src/features/diffs/nativeReviewDiffSurface.tsapps/mobile/src/features/terminal/nativeTerminalModule.ts- associated
*.test.tsfiles
The new NativeViewResolutionError conforms to the conventions:
- Imports the Effect schema module as a namespace via
import * as Schema from "effect/Schema", with no consolidated named imports from"effect". - Modeled with
Schema.TaggedErrorClassand a semantically precise tag (NativeViewResolutionError). - Carries stable structural context (
nativeModuleName) identifying the resource at the wrapping site, and preserves the immediate underlying failure as a requiredcause(Schema.Defect()). Since every construction wraps a real failure, requiringcauseis appropriate. messageis derived exclusively from the structural attribute (nativeModuleName) and does not stringify or depend oncause.- No redundant singleton discriminator (
operation/reason/kind/phase) is introduced alongside the precise tag.
The two consumer modules construct the error correctly at their respective resolution sites, preserving the caught error as cause. No convention violations were introduced or retained in the changed scope.
The agent made no additional tool calls beyond your initial Check Run Agent prompt.
Agent Credits: 25 credits
Loading