Skip to content

[codex] Structure native view resolution failures - #3353

Merged
juliusmarminge merged 2 commits into
mainfrom
codex/mobile-native-view-errors
Jun 20, 2026
Merged

juliusmarminge merged 2 commits into
mainfrom
codex/mobile-native-view-errors

Avoid repeated native view resolution failures

4b5ceb1
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Effect Service Conventions succeeded Jun 20, 2026 in 37s

Effect Service Conventions: All clear

All clear

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

Reviewed the changed TypeScript in scope:

  • apps/mobile/src/native/nativeViewResolutionError.ts (new)
  • apps/mobile/src/features/diffs/nativeReviewDiffSurface.ts
  • apps/mobile/src/features/terminal/nativeTerminalModule.ts
  • associated *.test.ts files

The new NativeViewResolutionError conforms to the conventions:

  • Imports the Effect schema module as a namespace via import * as Schema from "effect/Schema", with no consolidated named imports from "effect".
  • Modeled with Schema.TaggedErrorClass and a semantically precise tag (NativeViewResolutionError).
  • Carries stable structural context (nativeModuleName) identifying the resource at the wrapping site, and preserves the immediate underlying failure as a required cause (Schema.Defect()). Since every construction wraps a real failure, requiring cause is appropriate.
  • message is derived exclusively from the structural attribute (nativeModuleName) and does not stringify or depend on cause.
  • No redundant singleton discriminator (operation/reason/kind/phase) is introduced alongside the precise tag.

The two consumer modules construct the error correctly at their respective resolution sites, preserving the caught error as cause. No convention violations were introduced or retained in the changed scope.


The agent made no additional tool calls beyond your initial Check Run Agent prompt.


Agent Credits: 25 credits