[codex] Structure relay domain label errors - #3347
Merged
Merged
MacroscopeApp / Macroscope - Effect Service Conventions
succeeded
Jun 20, 2026 in 45s
Effect Service Conventions: All clear
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed the changed scope in infra/relay/src/deploymentConfig.ts and infra/relay/src//deploymentConfig.test.ts against the Effect service service conention con.
Findings:
import * as Schema from "effect/Schema"uses the correct subpath namespace import in both files.RelayPublicDomainLabelTooLongErroris defined withSchema.TaggedErrorClassand structured attributes (stage,label,maxLength), withmessagederived exclusively from those attributes — matching the error-modeling conventions.- This is a pure validation/domain error created without an underlying failure, so no
causeis required. - No redundant
operation/reason/kind/phasediscriminator is introduced; the precise tag carries the distinction. - The replaced generic
throw new Error(...)is now a structured, semantically precise error. - The test's
Schema.ispredicate is used directly (not a private constant wrapped by a redundant function), so it is not a violation.
No convention violations introduced or retained in the changed scope.
The agent made no additional tool calls beyond your initial Check Run Agent prompt.
Agent Credits: 25 credits
Loading