Skip to content

fix(web): preview annotation chip labels no longer end in a broken character #30345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spoukyii wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −3
Open

fix(web): preview annotation chip labels no longer end in a broken character #30345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
941f304
test(web): a preview annotation chip label cut beside an emoji
spoukyii Nov 3, 2026
4c16851
fix(web): preview annotation chip labels no longer end in a broken ch…
spoukyii Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/web/src/lib/composerContextRecords.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,14 @@ describe("composerContextRecords", () => {
expect(image).toMatchObject({ attachmentId: "uploaded-image" });
});

it("shortens a long annotation comment label without splitting an emoji", () => {
const record = previewAnnotationContextRecord({
...annotation,
comment: `${"a".repeat(46)}😀 and make the button bigger`,
});
expect(record.label).toBe(`${"a".repeat(46)}…`);
});

it("restores multiple edits on one target without parsing display strings", () => {
const styleChanges = [
...annotation.styleChanges,
Expand Down
9 changes: 6 additions & 3 deletions apps/web/src/lib/composerContextRecords.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,12 @@ export function pullRequestContextKindLabel(comment: ReviewCommentPresentation):
export function previewAnnotationContextLabel(annotation: PreviewAnnotationPayload): string {
const comment = annotation.comment.trim().replace(/\s+/g, " ");
if (comment) {
return comment.length > PREVIEW_LABEL_MAX_CHARS
? `${comment.slice(0, PREVIEW_LABEL_MAX_CHARS - 1)}…`
: comment;
if (comment.length <= PREVIEW_LABEL_MAX_CHARS) return comment;
let end = PREVIEW_LABEL_MAX_CHARS - 1;
const previous = comment.charCodeAt(end - 1);
const next = comment.charCodeAt(end);
if (previous >= 0xd800 && previous <= 0xdbff && next >= 0xdc00 && next <= 0xdfff) end -= 1;
return `${comment.slice(0, end)}…`;
}
return annotation.pageTitle?.trim() || "Preview annotation";
}
Expand Down
Loading