Skip to content

fix(web): drafts saved by older versions load instead of being wiped - #29828

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
saphid:fix/web-legacy-draft-selections
Nov 3, 2026
Merged

maria-rcks merged 1 commit into
pingdotgg:mainfrom
saphid:fix/web-legacy-draft-selections

fix(web): drafts saved by older versions load instead of being wiped

44da637
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Nov 3, 2026 in 2m 13s

Approved

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
Older saved drafts and sticky model choices now use the existing compatibility decoder instead of passing legacy values through unchanged. The change is confined to local draft loading and does not alter product defaults or external behavior.

Additional Thinking

Your Custom Policy

Neither additional restriction applies: this restores loading of saved user selections without changing product defaults, and adds no static-analysis suppression directives.

Code

Persisted draft and sticky per-provider model selections now decode through the existing ModelSelection schema rather than unchecked casts. The schema upgrades legacy provider identifiers and object-shaped options; invalid selections are omitted individually. This affects local composer-state hydration, not external systems. The ignored file was not reconstructed.

Review Context

Author is saphid; no ownership requirements were supplied. No unresolved review comments or correctness findings were supplied. The PR description reports a migration regression test passing with all 76 store tests and changed-file checks passing; these are author-reported results, not independently run checks. No blocking-severity configuration was supplied.

Verdict

The change is a narrowly scoped compatibility correction using existing schema transformations during local-state hydration. It preserves existing saved choices and limits invalid-data handling to individual selections. No obvious material exposure or product decision requires human judgment.

Notes:
No code owners found in target merge base ab06e2a


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.