Skip to content

fix(cursor): Cursor text generation names usage-limit failures #29748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 2 commits into from
Nov 3, 2026
+25 −9
Merged

fix(cursor): Cursor text generation names usage-limit failures #29748

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4193fc3
fix(cursor): failed Cursor text generation shows Cursor's reason
saphid Nov 3, 2026
9eee645
fix(cursor): Cursor text generation names usage-limit failures
saphid Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/provider-cursor/src/server/textGeneration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ describe("CursorTextGeneration", () => {
id: "run-cursor-partial-title-test",
status,
result: '{"title":"Partial title from a failed run."}',
...(status === "error" ? { error: { message: "Usage limit reached." } } : {}),
} satisfies RunResult;
cursorSdkMock.prompt.mockResolvedValueOnce(promptResult);
const generation = yield* makeCursorTextGeneration(cursorSettings, {
Expand All @@ -222,7 +223,7 @@ describe("CursorTextGeneration", () => {
expect(failure.detail).toBe(
status === "cancelled"
? "Cursor SDK request was cancelled."
: "Cursor SDK request finished with an error.",
: "Cursor SDK request finished with an error: Usage limit reached.",
);
expect(cursorSdkMock.close).toHaveBeenCalledOnce();
}).pipe(Effect.provide(layerTest)),
Expand Down
8 changes: 6 additions & 2 deletions packages/provider-cursor/src/server/textGeneration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,12 @@ function cursorSdkResultDetail(result: RunResult): string {
switch (result.status) {
case "cancelled":
return "Cursor SDK request was cancelled.";
case "error":
return "Cursor SDK request finished with an error.";
case "error": {
const message = result.error?.message.trim();
Comment thread
saphid marked this conversation as resolved.
Resolved
return message
? `Cursor SDK request finished with an error: ${message}`
: "Cursor SDK request finished with an error.";
}
case "finished":
return "Cursor SDK returned empty output.";
}
Expand Down
Loading