Repository navigation
perf(server): idle compaction reads only the latest run, live work and newest usage - #29648
Approved
- Eligibility
- Correctness
Note
More information about how approvability works can be found in our Help Center.
Details
Eligibility
This reduces idle-compaction reads to relevant live work and the active session’s newest usage. Existing compaction settings and eligibility safeguards remain unchanged, with no new persistent-data operations or product defaults.
Additional Thinking
Your Custom Policy
Default approvability criteria apply. The change optimizes reads without changing product defaults and adds no diagnostic-suppression directives, so neither additional human-review requirement is triggered.
Code
Narrows idle-compaction projection reads to the latest run, relevant active/rolled-back runs, the active provider session’s newest usage, and pending requests/transfers. New ProjectionStore filters are optional, leaving other callers unchanged. Existing settings, background-work, session, cache-expiry and duplicate-dispatch guards remain; no storage writes or migrations are added.
Review Context
Author is a repository admin and ping-devs member; no ownership requirement was supplied. There are no supplied unresolved review comments or correctness findings, and no check results or blocking-severity configuration were supplied. Assessed the supplied production diff and relevant consumers; respected the omitted-file scope.
Verdict
The understood change is a bounded read optimization for existing settings-gated idle compaction. Optional filters isolate its effect from other projection consumers, while existing eligibility and dispatch safeguards remain. No obvious material exposure or product-intent decision requires human judgment.
Notes:
No code owners found in target merge base 065a433
Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.