Skip to content

perf(server): stop tracing project enrichment cache reads #29640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Nov 2, 2026
Merged

perf(server): stop tracing project enrichment cache reads #29640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 52 additions & 48 deletions apps/server/src/project/ProjectEnrichmentService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,63 +210,67 @@ export const make = Effect.fn("ProjectEnrichmentService.make")(function* (
{ concurrency: "unbounded", discard: true },
);

const requestLane = Effect.fn("ProjectEnrichmentService.requestLane")(function* (
// Every project read lands here; only an actual enqueue gets a span, the resolve workers trace the work.
const requestLane = Effect.fnUntraced(function* (
lane: EnrichmentWorkLane,
workspaceRoot: string,
field: "repositoryIdentity" | "faviconPath",
) {
if (!(yield* reservePending(lane, workspaceRoot))) return;
if (!(yield* Queue.offer(lane.queue, workspaceRoot))) {
yield* removePending(lane, workspaceRoot);
yield* Effect.logWarning("Project metadata enrichment queue is full", {
workspaceRoot,
field,
});
}
yield* Effect.gen(function* () {
if (!(yield* Queue.offer(lane.queue, workspaceRoot))) {
yield* removePending(lane, workspaceRoot);
yield* Effect.logWarning("Project metadata enrichment queue is full", {
workspaceRoot,
field,
});
}
}).pipe(Effect.withSpan("ProjectEnrichmentService.requestLane"));
});

const peek: ProjectEnrichmentService["Service"]["peek"] = Effect.fn(
"ProjectEnrichmentService.peek",
)(function* (workspaceRoot) {
const [repositoryIdentity, faviconPath] = yield* Effect.all(
[
Cache.getSuccess(repositoryIdentityCache, workspaceRoot),
Cache.getSuccess(faviconCache, workspaceRoot),
] as const,
{ concurrency: "unbounded" },
);
return {
repositoryIdentity: availableValue(repositoryIdentity),
faviconPath: availableValue(faviconPath),
repositoryIdentityResolved: isSuccessfullyResolved(repositoryIdentity),
};
});
// peek/request/getAvailable run per project on every shell read, inside the caller's span; own spans were ~0ms noise.
const peek: ProjectEnrichmentService["Service"]["peek"] = Effect.fnUntraced(
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
function* (workspaceRoot) {
const [repositoryIdentity, faviconPath] = yield* Effect.all(
[
Cache.getSuccess(repositoryIdentityCache, workspaceRoot),
Cache.getSuccess(faviconCache, workspaceRoot),
] as const,
{ concurrency: "unbounded" },
);
return {
repositoryIdentity: availableValue(repositoryIdentity),
faviconPath: availableValue(faviconPath),
repositoryIdentityResolved: isSuccessfullyResolved(repositoryIdentity),
};
},
);

const request: ProjectEnrichmentService["Service"]["request"] = Effect.fn(
"ProjectEnrichmentService.request",
)(function* (workspaceRoot) {
const [hasRepositoryIdentity, hasFaviconPath] = yield* Effect.all(
[Cache.has(repositoryIdentityCache, workspaceRoot), Cache.has(faviconCache, workspaceRoot)],
{ concurrency: "unbounded" },
);
yield* Effect.all(
[
hasRepositoryIdentity
? Effect.void
: requestLane(repositoryIdentityLane, workspaceRoot, "repositoryIdentity"),
hasFaviconPath ? Effect.void : requestLane(faviconLane, workspaceRoot, "faviconPath"),
],
{ concurrency: "unbounded", discard: true },
);
});
const request: ProjectEnrichmentService["Service"]["request"] = Effect.fnUntraced(
function* (workspaceRoot) {
const [hasRepositoryIdentity, hasFaviconPath] = yield* Effect.all(
[Cache.has(repositoryIdentityCache, workspaceRoot), Cache.has(faviconCache, workspaceRoot)],
{ concurrency: "unbounded" },
);
yield* Effect.all(
[
hasRepositoryIdentity
? Effect.void
: requestLane(repositoryIdentityLane, workspaceRoot, "repositoryIdentity"),
hasFaviconPath ? Effect.void : requestLane(faviconLane, workspaceRoot, "faviconPath"),
],
{ concurrency: "unbounded", discard: true },
);
},
);

const getAvailable: ProjectEnrichmentService["Service"]["getAvailable"] = Effect.fn(
"ProjectEnrichmentService.getAvailable",
)(function* (workspaceRoot) {
const available = yield* peek(workspaceRoot);
yield* request(workspaceRoot);
return available;
});
const getAvailable: ProjectEnrichmentService["Service"]["getAvailable"] = Effect.fnUntraced(
function* (workspaceRoot) {
const available = yield* peek(workspaceRoot);
yield* request(workspaceRoot);
return available;
},
);

const readRepositoryIdentity: ProjectEnrichmentService["Service"]["readRepositoryIdentity"] =
Effect.fn("ProjectEnrichmentService.readRepositoryIdentity")(function* (workspaceRoot) {
Expand Down
Loading