Skip to content

feat(review): add missing Git and pull request review actions - #29412

Open
jakeleventhal wants to merge 22 commits into
pingdotgg:mainfrom
jakeleventhal:t3/dc3cc5dd
Open

jakeleventhal wants to merge 22 commits into
pingdotgg:mainfrom
jakeleventhal:t3/dc3cc5dd

fix(review): merge main and preserve review grouping

ef05f42
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check completed Nov 2, 2026 in 2m 20s

Needs Human Approval

  • Eligibility
  • Correctness (unavailable)

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
New diff panes now default to Uncommitted when local edits exist, while preserving saved selections. This product-default change and an added oxlint suppression each require human review.

Additional Thinking

Your Custom Policy

Both additional requirements apply. apps/web/src/diffPanelStore.ts changes the initial product selection from branch to unstaged when working-tree edits exist. apps/web/src/components/DiffPanel.tsx:294 adds an oxlint-disable-next-line directive suppressing t3code/no-unreasoned-state-sync. Either change independently requires human review.

Code

The reconstructed diff spans mobile/web review interfaces, shared review state and contracts, server Git/review services, and GitHub review operations. Verified changes include defaulting new web diff panes to Uncommitted when local edits exist, preserving saved selections, and adding an oxlint suppression for scope initialization.

Review Context

Author: jakeleventhal; ownership information was not supplied. The supplied review-thread check reports 31 resolved threads and no unresolved comments. No correctness findings, configured blocking severity, or CI results were supplied. Investigation established two explicit human-review triggers; the remaining large diff was not exhaustively assessed.

Verdict

Human review is explicitly required for the changed default review scope and the added lint suppression. A human must accept the initial Uncommitted view for users with local edits and authorize the diagnostic exception; saved selections remain preserved.

Notes:
No code owners found in target merge base 71646e0

Correctness (unavailable)
Per-review cost limit exceeded (workspace setting).


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.