Skip to content

fix(mobile): keep Android follow-up menus visible above the keyboard - #29225

Open
shivamhwp wants to merge 3 commits into
mainfrom
issue-watch/29201
Open

shivamhwp wants to merge 3 commits into
mainfrom
issue-watch/29201

merge: update Android menu fix with main

5e998b3
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Nov 3, 2026 in 2m 5s

Approved

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
Moves the Android keyboard-open menu fade to a fixed-size wrapper so native content can resize without clipping. Existing menu actions and defaults remain unchanged, with device verification supporting the limited presentation risk.

Additional Thinking

Your Custom Policy

Default approvability criteria apply. This presentation fix changes neither product defaults nor diagnostic-suppression directives, so neither additional human-review requirement is triggered.

Code

Adds a 120 ms fade on a fixed-size, touch-transparent wrapper around Android menus opened with the keyboard visible. The inner menu remains dynamically sized; positioning, scrolling, dismissal, action dispatch, and keyboard-dismissed presentation remain unchanged. Shared Android menu callers are affected, but no persistence or external-system behavior changes.

Review Context

Author has write access; no ownership requirement was supplied. No unresolved review comments or correctness findings were supplied. The PR description reports physical-device verification on Android 13 and 14, including constrained-height scrolling and first-tap selection. Those captures reference an earlier revision; the changed component and its popup/portal dependencies are unchanged between that revision and the reviewed head. Reported local checks were not used as a decision gate.

Verdict

The understood change is limited to transient Android menu presentation, with existing action semantics and keyboard handling preserved. Relevant device evidence supports the intended layout behavior, and no obvious material consequence requires human judgment.

Notes:
No code owners found in target merge base 7c22e24


Agent Credits: 30 credits
Approvability runs at a flat rate of 30 credits whenever the agent is asked for a verdict.